ipa: rpi: Make monoSensor() accessor const
diff mbox series

Message ID 20240519175650.17316-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit 807119d1e0d27ffe50b10ccfc6ee7bf64ea03e74
Headers show
Series
  • ipa: rpi: Make monoSensor() accessor const
Related show

Commit Message

Laurent Pinchart May 19, 2024, 5:56 p.m. UTC 
The ipa::RPi::IpaBase::monoSensor() function doesn't modify the class.
Make it const.

Fixes: 2031e2f29014 ("ipa: rpi: Add accessor function for monoSensor_")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/rpi/common/ipa_base.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: aee16c06913422a0ac84ee3217f87a9795e3c2d9

Comments

Kieran Bingham May 20, 2024, 9:59 a.m. UTC | #1 
Quoting Laurent Pinchart (2024-05-19 18:56:50)
> The ipa::RPi::IpaBase::monoSensor() function doesn't modify the class.
> Make it const.
> 
> Fixes: 2031e2f29014 ("ipa: rpi: Add accessor function for monoSensor_")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/rpi/common/ipa_base.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
> index a95cda1ffe51..1a811beb31f2 100644
> --- a/src/ipa/rpi/common/ipa_base.h
> +++ b/src/ipa/rpi/common/ipa_base.h
> @@ -49,7 +49,7 @@ public:
>         void processStats(const ProcessParams &params) override;
>  
>  protected:
> -       bool monoSensor()
> +       bool monoSensor() const
>         {
>                 return monoSensor_;
>         }
> 
> base-commit: aee16c06913422a0ac84ee3217f87a9795e3c2d9
> -- 
> Regards,
> 
> Laurent Pinchart
>
Jacopo Mondi May 23, 2024, 8:36 a.m. UTC | #2 
Hi think this got from review when applying patches ?

On Sun, May 19, 2024 at 08:56:50PM GMT, Laurent Pinchart wrote:
> The ipa::RPi::IpaBase::monoSensor() function doesn't modify the class.
> Make it const.
>
> Fixes: 2031e2f29014 ("ipa: rpi: Add accessor function for monoSensor_")
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

> ---
>  src/ipa/rpi/common/ipa_base.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
> index a95cda1ffe51..1a811beb31f2 100644
> --- a/src/ipa/rpi/common/ipa_base.h
> +++ b/src/ipa/rpi/common/ipa_base.h
> @@ -49,7 +49,7 @@ public:
>  	void processStats(const ProcessParams &params) override;
>
>  protected:
> -	bool monoSensor()
> +	bool monoSensor() const
>  	{
>  		return monoSensor_;
>  	}
>
> base-commit: aee16c06913422a0ac84ee3217f87a9795e3c2d9
> --
> Regards,
>
> Laurent Pinchart
>

Patch
diff mbox series 

diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
index a95cda1ffe51..1a811beb31f2 100644
--- a/src/ipa/rpi/common/ipa_base.h
+++ b/src/ipa/rpi/common/ipa_base.h
@@ -49,7 +49,7 @@  public:
 	void processStats(const ProcessParams &params) override;
 
 protected:
-	bool monoSensor()
+	bool monoSensor() const
 	{
 		return monoSensor_;
 	}