[v1,4/5] ipa: rpi: Move variables from private to protected
diff mbox series

Message ID 20240502080925.31730-5-naush@raspberrypi.com
State Superseded
Headers show
Series
  • Pre Raspberry Pi 5 support changes
Related show

Commit Message

Naushir Patuck May 2, 2024, 8:09 a.m. UTC
The following member variable will be used by the derived IPAs in an
upcoming commit, so make them protected:

lensPresent_
monoSensor_

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/ipa/rpi/common/ipa_base.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jacopo Mondi May 2, 2024, 10:05 a.m. UTC | #1
Hi Naush

On Thu, May 02, 2024 at 09:09:24AM GMT, Naushir Patuck wrote:
> The following member variable will be used by the derived IPAs in an
> upcoming commit, so make them protected:
>
> lensPresent_
> monoSensor_
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
   j

> ---
>  src/ipa/rpi/common/ipa_base.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
> index 512d7e8fe778..ebdc4d297abb 100644
> --- a/src/ipa/rpi/common/ipa_base.h
> +++ b/src/ipa/rpi/common/ipa_base.h
> @@ -71,6 +71,9 @@ protected:
>  	/* Whether the stitch block (if available) needs to swap buffers. */
>  	bool stitchSwapBuffers_;
>
> +	bool monoSensor_;
> +	bool lensPresent_;
> +
>  private:
>  	/* Number of metadata objects available in the context list. */
>  	static constexpr unsigned int numMetadataContexts = 16;
> @@ -96,9 +99,6 @@ private:
>
>  	std::map<unsigned int, MappedFrameBuffer> buffers_;
>
> -	bool lensPresent_;
> -	bool monoSensor_;
> -
>  	std::array<RPiController::Metadata, numMetadataContexts> rpiMetadata_;
>
>  	/*
> --
> 2.34.1
>

Patch
diff mbox series

diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
index 512d7e8fe778..ebdc4d297abb 100644
--- a/src/ipa/rpi/common/ipa_base.h
+++ b/src/ipa/rpi/common/ipa_base.h
@@ -71,6 +71,9 @@  protected:
 	/* Whether the stitch block (if available) needs to swap buffers. */
 	bool stitchSwapBuffers_;
 
+	bool monoSensor_;
+	bool lensPresent_;
+
 private:
 	/* Number of metadata objects available in the context list. */
 	static constexpr unsigned int numMetadataContexts = 16;
@@ -96,9 +99,6 @@  private:
 
 	std::map<unsigned int, MappedFrameBuffer> buffers_;
 
-	bool lensPresent_;
-	bool monoSensor_;
-
 	std::array<RPiController::Metadata, numMetadataContexts> rpiMetadata_;
 
 	/*