[v1,3/5] qemu: Print error logs on unit test failure
diff mbox series

Message ID 20240307221810.2109348-4-nicolas@ndufresne.ca
State Accepted
Headers show
Series
  • Fix various CI issues
Related show

Commit Message

Nicolas Dufresne March 7, 2024, 10:18 p.m. UTC
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>

The error logs very often holds the information needed to fix the
failure, don't hide it.

Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
---
 .gitlab-ci/test-libcamera-qemu.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham March 7, 2024, 10:33 p.m. UTC | #1
Quoting Nicolas Dufresne (2024-03-07 22:18:08)
> From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> 
> The error logs very often holds the information needed to fix the
> failure, don't hide it.
> 

Sounds good to me.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
>  .gitlab-ci/test-libcamera-qemu.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci/test-libcamera-qemu.sh b/.gitlab-ci/test-libcamera-qemu.sh
> index 068f2ff..f9de5ab 100755
> --- a/.gitlab-ci/test-libcamera-qemu.sh
> +++ b/.gitlab-ci/test-libcamera-qemu.sh
> @@ -26,7 +26,7 @@ libcamera_unit_test() {
>         virtme-ng --verbose --skip-modules --force-9p \
>                 --rwdir "$PWD/build" \
>                 --run /opt/linux/bzImage \
> -               --exec "meson test -C build --no-rebuild ; echo \\\$? > build/.test-status"
> +               --exec "meson test -C build --no-rebuild --print-errorlogs; echo \\\$? > build/.test-status"
>  
>         local status=$(cat build/.test-status)
>         echo "Test result exit state: $status"
> -- 
> 2.43.2
>

Patch
diff mbox series

diff --git a/.gitlab-ci/test-libcamera-qemu.sh b/.gitlab-ci/test-libcamera-qemu.sh
index 068f2ff..f9de5ab 100755
--- a/.gitlab-ci/test-libcamera-qemu.sh
+++ b/.gitlab-ci/test-libcamera-qemu.sh
@@ -26,7 +26,7 @@  libcamera_unit_test() {
 	virtme-ng --verbose --skip-modules --force-9p \
 		--rwdir "$PWD/build" \
 		--run /opt/linux/bzImage \
-		--exec "meson test -C build --no-rebuild ; echo \\\$? > build/.test-status"
+		--exec "meson test -C build --no-rebuild --print-errorlogs; echo \\\$? > build/.test-status"
 
 	local status=$(cat build/.test-status)
 	echo "Test result exit state: $status"