| Message ID | 20231020084002.30665-1-naush@raspberrypi.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi all, Given that these changes are specific to the RPi IPA, I'm not sure folks would want to dive in deep and do a review. But of course, feel free to do so if time permits :-) Since both David and I have added R-B tags to the patches, should I go ahead and make a git request-pull for this series to be merged? Regards, Naush On Fri, 20 Oct 2023 at 09:40, Naushir Patuck <naush@raspberrypi.com> wrote: > > Hi all, > > Here is another small set of patches adding preliminary Pi 5 support to > libcamera. This change is predominately related to HDR functionality, and only > includes changes to the Raspberry Pi IPA algorithms. > > As before, the actual pipeline handler and IPA for Pi 5 is not yet published to > the mailing list, but can be found at https://github.com/raspberrypi/libcamera. > > Thanks, > Naush > > David Plowman (5): > ipa: rpi: hdr: Add the ability to alter the LSC table > ipa: rpi: alsc: Do not re-read the alsc.status metadata > ipa: rpi: agc: Allow AGC channels to avoid using "fast desaturation" > ipa: rpi: agc: Fetch AWB status in the prepare method > ipa: rpi: agc: Make AGC controls affect all channels > > Naushir Patuck (1): > ipa: rpi: vc4: Move denoise control handling into the VC4 derived IPA > > src/ipa/rpi/common/ipa_base.cpp | 55 ++----- > src/ipa/rpi/controller/agc_algorithm.h | 11 +- > src/ipa/rpi/controller/rpi/agc.cpp | 51 +++--- > src/ipa/rpi/controller/rpi/agc.h | 13 +- > src/ipa/rpi/controller/rpi/agc_channel.cpp | 23 ++- > src/ipa/rpi/controller/rpi/agc_channel.h | 1 + > src/ipa/rpi/controller/rpi/alsc.cpp | 22 +-- > src/ipa/rpi/controller/rpi/hdr.cpp | 183 ++++++++++++++------- > src/ipa/rpi/controller/rpi/hdr.h | 18 +- > src/ipa/rpi/vc4/vc4.cpp | 35 +++- > 10 files changed, 237 insertions(+), 175 deletions(-) > > -- > 2.34.1 >
Hi Naush, Quoting Naushir Patuck via libcamera-devel (2023-10-24 09:08:36) > Hi all, > > Given that these changes are specific to the RPi IPA, I'm not sure > folks would want to dive in deep and do a review. But of course, feel > free to do so if time permits :-) > > Since both David and I have added R-B tags to the patches, should I go > ahead and make a git request-pull for this series to be merged? A PR here is fine with me. -- Regards Kieran > > Regards, > Naush > > On Fri, 20 Oct 2023 at 09:40, Naushir Patuck <naush@raspberrypi.com> wrote: > > > > Hi all, > > > > Here is another small set of patches adding preliminary Pi 5 support to > > libcamera. This change is predominately related to HDR functionality, and only > > includes changes to the Raspberry Pi IPA algorithms. > > > > As before, the actual pipeline handler and IPA for Pi 5 is not yet published to > > the mailing list, but can be found at https://github.com/raspberrypi/libcamera. > > > > Thanks, > > Naush > > > > David Plowman (5): > > ipa: rpi: hdr: Add the ability to alter the LSC table > > ipa: rpi: alsc: Do not re-read the alsc.status metadata > > ipa: rpi: agc: Allow AGC channels to avoid using "fast desaturation" > > ipa: rpi: agc: Fetch AWB status in the prepare method > > ipa: rpi: agc: Make AGC controls affect all channels > > > > Naushir Patuck (1): > > ipa: rpi: vc4: Move denoise control handling into the VC4 derived IPA > > > > src/ipa/rpi/common/ipa_base.cpp | 55 ++----- > > src/ipa/rpi/controller/agc_algorithm.h | 11 +- > > src/ipa/rpi/controller/rpi/agc.cpp | 51 +++--- > > src/ipa/rpi/controller/rpi/agc.h | 13 +- > > src/ipa/rpi/controller/rpi/agc_channel.cpp | 23 ++- > > src/ipa/rpi/controller/rpi/agc_channel.h | 1 + > > src/ipa/rpi/controller/rpi/alsc.cpp | 22 +-- > > src/ipa/rpi/controller/rpi/hdr.cpp | 183 ++++++++++++++------- > > src/ipa/rpi/controller/rpi/hdr.h | 18 +- > > src/ipa/rpi/vc4/vc4.cpp | 35 +++- > > 10 files changed, 237 insertions(+), 175 deletions(-) > > > > -- > > 2.34.1 > >