| Message ID | 20191006053226.8976-1-laurent.pinchart@ideasonboard.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thanks for your series. On 2019-10-06 08:32:17 +0300, Laurent Pinchart wrote: > Hello, > > This series fixes several issues with the Timer class (in patches 2/9, > 5/9 and 6/9), and extends the class with support for absolute deadlines > (patch 8/9) which should be useful for IPAs. > > Please see individual patches for details. I read all the patches and updated the IPA work to make use of this, and it still works ;-) I plan to send out the next IPA version depending on this series. For the whole series: Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > > Laurent Pinchart (9): > libcamera: timer: Remove the interval() method > libcamera: timer: Don't reset deadline after time out > test: timer: Test that deadline() isn't reset upon time out > test: timer: Test that a timer can be restarted before it expires > libcamera: timer: Allow restarting a timer before expiration > libcamera: timer: Forbid starting or stopping timer from another > thread > test: timer-thread: Test starting a timer from another thread > libcamera: timer: Add start() method with absolute deadline > test: timer: Test start() with absolute deadline > > include/libcamera/timer.h | 6 +-- > src/libcamera/timer.cpp | 73 +++++++++++++++++++++++--------- > src/qcam/qt_event_dispatcher.cpp | 7 ++- > test/timer-thread.cpp | 58 +++++++++++++++++++------ > test/timer.cpp | 54 +++++++++++++++++++---- > 5 files changed, 153 insertions(+), 45 deletions(-) > > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hello, This series fixes several issues with the Timer class (in patches 2/9, 5/9 and 6/9), and extends the class with support for absolute deadlines (patch 8/9) which should be useful for IPAs. Please see individual patches for details. Laurent Pinchart (9): libcamera: timer: Remove the interval() method libcamera: timer: Don't reset deadline after time out test: timer: Test that deadline() isn't reset upon time out test: timer: Test that a timer can be restarted before it expires libcamera: timer: Allow restarting a timer before expiration libcamera: timer: Forbid starting or stopping timer from another thread test: timer-thread: Test starting a timer from another thread libcamera: timer: Add start() method with absolute deadline test: timer: Test start() with absolute deadline include/libcamera/timer.h | 6 +-- src/libcamera/timer.cpp | 73 +++++++++++++++++++++++--------- src/qcam/qt_event_dispatcher.cpp | 7 ++- test/timer-thread.cpp | 58 +++++++++++++++++++------ test/timer.cpp | 54 +++++++++++++++++++---- 5 files changed, 153 insertions(+), 45 deletions(-)