[libcamera-devel,15/20] pipeline: rpi: Make color space members in RPiCameraConfiguration public
diff mbox series

Message ID 20231006132000.23504-16-naush@raspberrypi.com
State Superseded
Headers show
Series
  • Raspberry Pi: Preliminary PiSP support
Related show

Commit Message

Naushir Patuck Oct. 6, 2023, 1:19 p.m. UTC 
This allows them to be accessed by the pipeline handlers when needed.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
---
 src/libcamera/pipeline/rpi/common/pipeline_base.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jacopo Mondi Oct. 12, 2023, 10:09 a.m. UTC | #1 
Hi Naush

On Fri, Oct 06, 2023 at 02:19:55PM +0100, Naushir Patuck via libcamera-devel wrote:
> This allows them to be accessed by the pipeline handlers when needed.
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> Reviewed-by: David Plowman <david.plowman@raspberrypi.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> ---
>  src/libcamera/pipeline/rpi/common/pipeline_base.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h
> index 0c4a59b7f590..267eef1102f1 100644
> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.h
> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h
> @@ -273,9 +273,6 @@ public:
>  	std::vector<StreamParams> rawStreams_;
>  	std::vector<StreamParams> outStreams_;
>
> -private:
> -	const CameraData *data_;
> -
>  	/*
>  	 * Store the colour spaces that all our streams will have. RGB format streams
>  	 * will have the same colorspace as YUV streams, with YCbCr field cleared and
> @@ -283,6 +280,9 @@ private:
>  	 */
>  	std::optional<ColorSpace> yuvColorSpace_;
>  	std::optional<ColorSpace> rgbColorSpace_;
> +
> +private:
> +	const CameraData *data_;
>  };
>
>  } /* namespace RPi */
> --
> 2.34.1
>

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h
index 0c4a59b7f590..267eef1102f1 100644
--- a/src/libcamera/pipeline/rpi/common/pipeline_base.h
+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h
@@ -273,9 +273,6 @@  public:
 	std::vector<StreamParams> rawStreams_;
 	std::vector<StreamParams> outStreams_;
 
-private:
-	const CameraData *data_;
-
 	/*
 	 * Store the colour spaces that all our streams will have. RGB format streams
 	 * will have the same colorspace as YUV streams, with YCbCr field cleared and
@@ -283,6 +280,9 @@  private:
 	 */
 	std::optional<ColorSpace> yuvColorSpace_;
 	std::optional<ColorSpace> rgbColorSpace_;
+
+private:
+	const CameraData *data_;
 };
 
 } /* namespace RPi */