[libcamera-devel] README.rst: Drop recommendation to install meson using pip3
diff mbox series

Message ID 20230914220313.14361-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit e5f0846695908ff162206ec120c0614df0eca3f8
Headers show
Series
  • [libcamera-devel] README.rst: Drop recommendation to install meson using pip3
Related show

Commit Message

Laurent Pinchart Sept. 14, 2023, 10:03 p.m. UTC 
Usage of pip3 to install meson may result in a different meson version
available for the local user and for root. This causes issues when
running `meson install` (directly or through `ninja install`):
Installing to a system location will request elevated privileges and use
the system meson version to install files, which may fail to unpickle
data pickled with the meson version for the local user.

As all major distributions now provide a recent-enough version of meson,
usage of pip3 is not longer needed in most cases, and shouldn't be
recommended. Drop it.

While at it, update the version of meson listed in the documentation to
match the required version.

Bug: https://bugs.libcamera.org/show_bug.cgi?id=199
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 README.rst | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)


base-commit: 58e501c71c47e57f02afde1bd296a037038cd6d5
prerequisite-patch-id: d9c748d5c7361a9489176ff3f3e4c4e807e93b5a
prerequisite-patch-id: 79b114f63d2d0dce812a9c9d3033b4a915037e01
prerequisite-patch-id: 0fec5b708550ac685fd0dee76120932b272b2a74
prerequisite-patch-id: c9f2ac2f7d50930d7164ff732f4fb499238715e6
prerequisite-patch-id: b7d57dd39a032a92e05d3d4e22bb821b085e2291
prerequisite-patch-id: 084351f43f3f5f6886451a5b53bd7179f1b8b85f
prerequisite-patch-id: d234444f68b826d24c6f4d5371873e18766e88e3
prerequisite-patch-id: 66dfe4522bc50ed0454f07c747c93c300c854a86
prerequisite-patch-id: 6d8b7e073016a3ccfe689d071f9c03a911538067
prerequisite-patch-id: de720d5310e0889e748deb63556ac797cb7743fa
prerequisite-patch-id: ec1ec005eab22d9e70111c050b1e244027ce1fba
prerequisite-patch-id: 4acc618067ba4cc796c2bc62dea12b652b2d0b8d
prerequisite-patch-id: c0e4433160c2d2af0245fc06de871063e8db9d74
prerequisite-patch-id: 49b44116fbed84761795b52523ce1990ca1ba29e
prerequisite-patch-id: a001ddcd0401b7fc09ad2ed8b70689a46046d6b3

Comments

Laurent Pinchart Sept. 14, 2023, 10:08 p.m. UTC | #1 
On Fri, Sep 15, 2023 at 01:03:13AM +0300, Laurent Pinchart via libcamera-devel wrote:
> Usage of pip3 to install meson may result in a different meson version
> available for the local user and for root. This causes issues when
> running `meson install` (directly or through `ninja install`):
> Installing to a system location will request elevated privileges and use
> the system meson version to install files, which may fail to unpickle
> data pickled with the meson version for the local user.
> 
> As all major distributions now provide a recent-enough version of meson,
> usage of pip3 is not longer needed in most cases, and shouldn't be
> recommended. Drop it.
> 
> While at it, update the version of meson listed in the documentation to
> match the required version.
> 
> Bug: https://bugs.libcamera.org/show_bug.cgi?id=199
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  README.rst | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index df2818e1f598..6eed72389a86 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -47,15 +47,7 @@ A C++ toolchain: [required]
>          Either {g++, clang}
>  
>  Meson Build system: [required]
> -        meson (>= 0.56) ninja-build pkg-config
> -
> -        If your distribution doesn't provide a recent enough version of meson,
> -        you can install or upgrade it using pip3.
> -
> -        .. code::
> -
> -            pip3 install --user meson
> -            pip3 install --user --upgrade meson
> +        meson (>= 0.57) ninja-build pkg-config
>  
>  for the libcamera core: [required]
>          libyaml-dev python3-yaml python3-ply python3-jinja2
> 
> base-commit: 58e501c71c47e57f02afde1bd296a037038cd6d5
> prerequisite-patch-id: d9c748d5c7361a9489176ff3f3e4c4e807e93b5a
> prerequisite-patch-id: 79b114f63d2d0dce812a9c9d3033b4a915037e01
> prerequisite-patch-id: 0fec5b708550ac685fd0dee76120932b272b2a74
> prerequisite-patch-id: c9f2ac2f7d50930d7164ff732f4fb499238715e6
> prerequisite-patch-id: b7d57dd39a032a92e05d3d4e22bb821b085e2291
> prerequisite-patch-id: 084351f43f3f5f6886451a5b53bd7179f1b8b85f
> prerequisite-patch-id: d234444f68b826d24c6f4d5371873e18766e88e3
> prerequisite-patch-id: 66dfe4522bc50ed0454f07c747c93c300c854a86
> prerequisite-patch-id: 6d8b7e073016a3ccfe689d071f9c03a911538067
> prerequisite-patch-id: de720d5310e0889e748deb63556ac797cb7743fa
> prerequisite-patch-id: ec1ec005eab22d9e70111c050b1e244027ce1fba
> prerequisite-patch-id: 4acc618067ba4cc796c2bc62dea12b652b2d0b8d
> prerequisite-patch-id: c0e4433160c2d2af0245fc06de871063e8db9d74
> prerequisite-patch-id: 49b44116fbed84761795b52523ce1990ca1ba29e
> prerequisite-patch-id: a001ddcd0401b7fc09ad2ed8b70689a46046d6b3

Oops, I had selected the wrong base. You can ignore this, the patch
applies correctly on top of the master branch.
Kieran Bingham Sept. 14, 2023, 10:42 p.m. UTC | #2 
Quoting Laurent Pinchart (2023-09-14 23:03:13)
> Usage of pip3 to install meson may result in a different meson version
> available for the local user and for root. This causes issues when
> running `meson install` (directly or through `ninja install`):
> Installing to a system location will request elevated privileges and use
> the system meson version to install files, which may fail to unpickle
> data pickled with the meson version for the local user.
> 
> As all major distributions now provide a recent-enough version of meson,
> usage of pip3 is not longer needed in most cases, and shouldn't be
> recommended. Drop it.
> 
> While at it, update the version of meson listed in the documentation to
> match the required version.
> 
> Bug: https://bugs.libcamera.org/show_bug.cgi?id=199
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  README.rst | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index df2818e1f598..6eed72389a86 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -47,15 +47,7 @@ A C++ toolchain: [required]
>          Either {g++, clang}
>  
>  Meson Build system: [required]
> -        meson (>= 0.56) ninja-build pkg-config
> -
> -        If your distribution doesn't provide a recent enough version of meson,
> -        you can install or upgrade it using pip3.
> -
> -        .. code::
> -
> -            pip3 install --user meson
> -            pip3 install --user --upgrade meson
> +        meson (>= 0.57) ninja-build pkg-config
>  
>  for the libcamera core: [required]
>          libyaml-dev python3-yaml python3-ply python3-jinja2
> 
> base-commit: 58e501c71c47e57f02afde1bd296a037038cd6d5
> prerequisite-patch-id: d9c748d5c7361a9489176ff3f3e4c4e807e93b5a
> prerequisite-patch-id: 79b114f63d2d0dce812a9c9d3033b4a915037e01
> prerequisite-patch-id: 0fec5b708550ac685fd0dee76120932b272b2a74
> prerequisite-patch-id: c9f2ac2f7d50930d7164ff732f4fb499238715e6
> prerequisite-patch-id: b7d57dd39a032a92e05d3d4e22bb821b085e2291
> prerequisite-patch-id: 084351f43f3f5f6886451a5b53bd7179f1b8b85f
> prerequisite-patch-id: d234444f68b826d24c6f4d5371873e18766e88e3
> prerequisite-patch-id: 66dfe4522bc50ed0454f07c747c93c300c854a86
> prerequisite-patch-id: 6d8b7e073016a3ccfe689d071f9c03a911538067
> prerequisite-patch-id: de720d5310e0889e748deb63556ac797cb7743fa
> prerequisite-patch-id: ec1ec005eab22d9e70111c050b1e244027ce1fba
> prerequisite-patch-id: 4acc618067ba4cc796c2bc62dea12b652b2d0b8d
> prerequisite-patch-id: c0e4433160c2d2af0245fc06de871063e8db9d74
> prerequisite-patch-id: 49b44116fbed84761795b52523ce1990ca1ba29e
> prerequisite-patch-id: a001ddcd0401b7fc09ad2ed8b70689a46046d6b3
> -- 
> Regards,
> 
> Laurent Pinchart
>
Mattijs Korpershoek Sept. 15, 2023, 7:13 a.m. UTC | #3 
On ven., sept. 15, 2023 at 01:03, Laurent Pinchart via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote:

> Usage of pip3 to install meson may result in a different meson version
> available for the local user and for root. This causes issues when
> running `meson install` (directly or through `ninja install`):
> Installing to a system location will request elevated privileges and use
> the system meson version to install files, which may fail to unpickle
> data pickled with the meson version for the local user.
>
> As all major distributions now provide a recent-enough version of meson,
> usage of pip3 is not longer needed in most cases, and shouldn't be
> recommended. Drop it.
>
> While at it, update the version of meson listed in the documentation to
> match the required version.
>
> Bug: https://bugs.libcamera.org/show_bug.cgi?id=199
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

> ---
>  README.rst | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/README.rst b/README.rst
> index df2818e1f598..6eed72389a86 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -47,15 +47,7 @@ A C++ toolchain: [required]
>          Either {g++, clang}
>  
>  Meson Build system: [required]
> -        meson (>= 0.56) ninja-build pkg-config
> -
> -        If your distribution doesn't provide a recent enough version of meson,
> -        you can install or upgrade it using pip3.
> -
> -        .. code::
> -
> -            pip3 install --user meson
> -            pip3 install --user --upgrade meson
> +        meson (>= 0.57) ninja-build pkg-config
>  
>  for the libcamera core: [required]
>          libyaml-dev python3-yaml python3-ply python3-jinja2
>
> base-commit: 58e501c71c47e57f02afde1bd296a037038cd6d5
> prerequisite-patch-id: d9c748d5c7361a9489176ff3f3e4c4e807e93b5a
> prerequisite-patch-id: 79b114f63d2d0dce812a9c9d3033b4a915037e01
> prerequisite-patch-id: 0fec5b708550ac685fd0dee76120932b272b2a74
> prerequisite-patch-id: c9f2ac2f7d50930d7164ff732f4fb499238715e6
> prerequisite-patch-id: b7d57dd39a032a92e05d3d4e22bb821b085e2291
> prerequisite-patch-id: 084351f43f3f5f6886451a5b53bd7179f1b8b85f
> prerequisite-patch-id: d234444f68b826d24c6f4d5371873e18766e88e3
> prerequisite-patch-id: 66dfe4522bc50ed0454f07c747c93c300c854a86
> prerequisite-patch-id: 6d8b7e073016a3ccfe689d071f9c03a911538067
> prerequisite-patch-id: de720d5310e0889e748deb63556ac797cb7743fa
> prerequisite-patch-id: ec1ec005eab22d9e70111c050b1e244027ce1fba
> prerequisite-patch-id: 4acc618067ba4cc796c2bc62dea12b652b2d0b8d
> prerequisite-patch-id: c0e4433160c2d2af0245fc06de871063e8db9d74
> prerequisite-patch-id: 49b44116fbed84761795b52523ce1990ca1ba29e
> prerequisite-patch-id: a001ddcd0401b7fc09ad2ed8b70689a46046d6b3
> -- 
> Regards,
>
> Laurent Pinchart

Patch
diff mbox series 

diff --git a/README.rst b/README.rst
index df2818e1f598..6eed72389a86 100644
--- a/README.rst
+++ b/README.rst
@@ -47,15 +47,7 @@  A C++ toolchain: [required]
         Either {g++, clang}
 
 Meson Build system: [required]
-        meson (>= 0.56) ninja-build pkg-config
-
-        If your distribution doesn't provide a recent enough version of meson,
-        you can install or upgrade it using pip3.
-
-        .. code::
-
-            pip3 install --user meson
-            pip3 install --user --upgrade meson
+        meson (>= 0.57) ninja-build pkg-config
 
 for the libcamera core: [required]
         libyaml-dev python3-yaml python3-ply python3-jinja2