[libcamera-devel,v3,0/2] Mono sensor improvements
mbox series

Message ID 20230605082605.9993-1-naush@raspberrypi.com
Headers show
Series
  • Mono sensor improvements
Related show

Message

Naushir Patuck June 5, 2023, 8:26 a.m. UTC 
Hi,

Some small updates for v3:

- Add a \todo in patch 1/2 to note the need for optional vars in the mojom
  interface.
- Pass IPACameraSensorInfo into ipa->init() so that the ControlInfoMap is
  (more) correctly setup before the call to ipa->configure().

Regards,
Naush

Naushir Patuck (2):
  camera_sensor: ipa: core: Add CFA pattern to IPACameraSensorInfo
  ipa: rpi: Handle controls for mono variant sensors

 include/libcamera/ipa/core.mojom              | 13 +++++++
 include/libcamera/ipa/raspberrypi.mojom       |  1 +
 src/ipa/rpi/common/ipa_base.cpp               | 39 ++++++++++++++++---
 src/ipa/rpi/common/ipa_base.h                 |  1 +
 src/libcamera/camera_sensor.cpp               |  3 ++
 .../pipeline/rpi/common/pipeline_base.cpp     | 10 ++++-
 6 files changed, 61 insertions(+), 6 deletions(-)

Comments

Laurent Pinchart June 5, 2023, 10:05 a.m. UTC | #1 
Hi Naush,

On Mon, Jun 05, 2023 at 09:26:03AM +0100, Naushir Patuck via libcamera-devel wrote:
> Hi,
> 
> Some small updates for v3:
> 
> - Add a \todo in patch 1/2 to note the need for optional vars in the mojom
>   interface.
> - Pass IPACameraSensorInfo into ipa->init() so that the ControlInfoMap is
>   (more) correctly setup before the call to ipa->configure().

Thank you. I've pushed the patches.

In the future, would it be possible to record changelogs per patch ? You
can add them directly to the commit message when you amend commits, with
a '---' separator below the Signed-off-by and other tags.

> Naushir Patuck (2):
>   camera_sensor: ipa: core: Add CFA pattern to IPACameraSensorInfo
>   ipa: rpi: Handle controls for mono variant sensors
> 
>  include/libcamera/ipa/core.mojom              | 13 +++++++
>  include/libcamera/ipa/raspberrypi.mojom       |  1 +
>  src/ipa/rpi/common/ipa_base.cpp               | 39 ++++++++++++++++---
>  src/ipa/rpi/common/ipa_base.h                 |  1 +
>  src/libcamera/camera_sensor.cpp               |  3 ++
>  .../pipeline/rpi/common/pipeline_base.cpp     | 10 ++++-
>  6 files changed, 61 insertions(+), 6 deletions(-)