[libcamera-devel] libcamera: camera_sensor: Add Sony IMX327 sensor properties
diff mbox series

Message ID 20230523-imx327-properties-v1-1-bd1e3933ec84@skidata.com
State Accepted
Headers show
Series
  • [libcamera-devel] libcamera: camera_sensor: Add Sony IMX327 sensor properties
Related show

Commit Message

Benjamin Bara May 23, 2023, 5:12 p.m. UTC 
From: Benjamin Bara <benjamin.bara@skidata.com>

Copy the sensor properties from Sony IMX290, as the IMX327 is a variant
of it.

Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com>
---
Hi,

I forgot to add the properties when adding the helper last week.
These could also be squashed :)
---
 src/libcamera/camera_sensor_properties.cpp | 4 ++++
 1 file changed, 4 insertions(+)


---
base-commit: e8fccaea46b9e545282cd37d54b1acb168608a46
change-id: 20230523-imx327-properties-61e7af857ba1

Best regards,

Comments

Jacopo Mondi May 24, 2023, 12:49 p.m. UTC | #1 
Hi Benjamin

On Tue, May 23, 2023 at 07:12:43PM +0200, Benjamin Bara via libcamera-devel wrote:
> From: Benjamin Bara <benjamin.bara@skidata.com>
>
> Copy the sensor properties from Sony IMX290, as the IMX327 is a variant
> of it.
>
> Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com>

This matches the information on the product brief

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
   j


> ---
> Hi,
>
> I forgot to add the properties when adding the helper last week.
> These could also be squashed :)
> ---
>  src/libcamera/camera_sensor_properties.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index fefb8afc..d35055d4 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -103,6 +103,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>  			.unitCellSize = { 2900, 2900 },
>  			.testPatternModes = {},
>  		} },
> +		{ "imx327", {
> +			.unitCellSize = { 2900, 2900 },
> +			.testPatternModes = {},
> +		} },
>  		{ "imx296", {
>  			.unitCellSize = { 3450, 3450 },
>  			.testPatternModes = {},
>
> ---
> base-commit: e8fccaea46b9e545282cd37d54b1acb168608a46
> change-id: 20230523-imx327-properties-61e7af857ba1
>
> Best regards,
> --
> Benjamin Bara <benjamin.bara@skidata.com>
>
Kieran Bingham May 24, 2023, 12:57 p.m. UTC | #2 
Quoting Benjamin Bara via libcamera-devel (2023-05-23 18:12:43)
> From: Benjamin Bara <benjamin.bara@skidata.com>
> 
> Copy the sensor properties from Sony IMX290, as the IMX327 is a variant
> of it.
> 
> Signed-off-by: Benjamin Bara <benjamin.bara@skidata.com>
> ---
> Hi,
> 
> I forgot to add the properties when adding the helper last week.
> These could also be squashed :)
> ---
>  src/libcamera/camera_sensor_properties.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
> index fefb8afc..d35055d4 100644
> --- a/src/libcamera/camera_sensor_properties.cpp
> +++ b/src/libcamera/camera_sensor_properties.cpp
> @@ -103,6 +103,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>                         .unitCellSize = { 2900, 2900 },
>                         .testPatternModes = {},
>                 } },
> +               { "imx327", {

I think we'd probably keep these in sort order based on the string here.
I can move it while applying.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> +                       .unitCellSize = { 2900, 2900 },
> +                       .testPatternModes = {},
> +               } },
>                 { "imx296", {
>                         .unitCellSize = { 3450, 3450 },
>                         .testPatternModes = {},
> 
> ---
> base-commit: e8fccaea46b9e545282cd37d54b1acb168608a46
> change-id: 20230523-imx327-properties-61e7af857ba1
> 
> Best regards,
> -- 
> Benjamin Bara <benjamin.bara@skidata.com>
>

Patch
diff mbox series 

diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
index fefb8afc..d35055d4 100644
--- a/src/libcamera/camera_sensor_properties.cpp
+++ b/src/libcamera/camera_sensor_properties.cpp
@@ -103,6 +103,10 @@  const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
 			.unitCellSize = { 2900, 2900 },
 			.testPatternModes = {},
 		} },
+		{ "imx327", {
+			.unitCellSize = { 2900, 2900 },
+			.testPatternModes = {},
+		} },
 		{ "imx296", {
 			.unitCellSize = { 3450, 3450 },
 			.testPatternModes = {},