[libcamera-devel,v6,10/10] ipa: rkisp1: Add OV5675 tuning file

18517 diff mbox series

Add the OV5675 tuning file with default values and enabled AF algorithm.

Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
---
 src/ipa/rkisp1/data/meson.build |  1 +
 src/ipa/rkisp1/data/ov5675.yaml | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 src/ipa/rkisp1/data/ov5675.yaml

Hi Daniel

On Fri, Mar 31, 2023 at 10:19:30AM +0200, Daniel Semkowicz via libcamera-devel wrote:
> Add the OV5675 tuning file with default values and enabled AF algorithm.
>
> Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
> ---
>  src/ipa/rkisp1/data/meson.build |  1 +
>  src/ipa/rkisp1/data/ov5675.yaml | 18 ++++++++++++++++++
>  2 files changed, 19 insertions(+)
>  create mode 100644 src/ipa/rkisp1/data/ov5675.yaml
>
> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
> index f5e9fa75..1fdce2c9 100644
> --- a/src/ipa/rkisp1/data/meson.build
> +++ b/src/ipa/rkisp1/data/meson.build
> @@ -4,6 +4,7 @@ conf_files = files([
>      'imx219.yaml',
>      'ov4689.yaml',
>      'ov5640.yaml',
> +    'ov5675.yaml',
>      'uncalibrated.yaml',
>  ])
>
> diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml
> new file mode 100644
> index 00000000..4f3da897
> --- /dev/null
> +++ b/src/ipa/rkisp1/data/ov5675.yaml
> @@ -0,0 +1,18 @@
> +# SPDX-License-Identifier: CC0-1.0
> +%YAML 1.1
> +---
> +version: 1
> +algorithms:
> +  - Af:
> +      coarse-search-step: 30
> +      fine-search-step: 1
> +      fine-search-range: 5
> +      max-variance-change: 0.5
> +      wait-frames-lens: 2 # tuned for 30fps stream
> +      isp-threshold: 128
> +      isp-var-shift: 4
> +  - Agc:
> +  - Awb:
> +  - BlackLevelCorrection:

BLC without a vlaue will assume 256. If we want to merge this I would
prefer to have the actual black level value measured.

If you agree I can remove it when applying the patch

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>


> +  - ColorProcessing:
> +...
> --
> 2.39.2
>

Hi Jacopo,

On Mon, Apr 3, 2023 at 2:37 PM Jacopo Mondi
<jacopo.mondi@ideasonboard.com> wrote:
>
> Hi Daniel
>
> On Fri, Mar 31, 2023 at 10:19:30AM +0200, Daniel Semkowicz via libcamera-devel wrote:
> > Add the OV5675 tuning file with default values and enabled AF algorithm.
> >
> > Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
> > ---
> >  src/ipa/rkisp1/data/meson.build |  1 +
> >  src/ipa/rkisp1/data/ov5675.yaml | 18 ++++++++++++++++++
> >  2 files changed, 19 insertions(+)
> >  create mode 100644 src/ipa/rkisp1/data/ov5675.yaml
> >
> > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
> > index f5e9fa75..1fdce2c9 100644
> > --- a/src/ipa/rkisp1/data/meson.build
> > +++ b/src/ipa/rkisp1/data/meson.build
> > @@ -4,6 +4,7 @@ conf_files = files([
> >      'imx219.yaml',
> >      'ov4689.yaml',
> >      'ov5640.yaml',
> > +    'ov5675.yaml',
> >      'uncalibrated.yaml',
> >  ])
> >
> > diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml
> > new file mode 100644
> > index 00000000..4f3da897
> > --- /dev/null
> > +++ b/src/ipa/rkisp1/data/ov5675.yaml
> > @@ -0,0 +1,18 @@
> > +# SPDX-License-Identifier: CC0-1.0
> > +%YAML 1.1
> > +---
> > +version: 1
> > +algorithms:
> > +  - Af:
> > +      coarse-search-step: 30
> > +      fine-search-step: 1
> > +      fine-search-range: 5
> > +      max-variance-change: 0.5
> > +      wait-frames-lens: 2 # tuned for 30fps stream
> > +      isp-threshold: 128
> > +      isp-var-shift: 4
> > +  - Agc:
> > +  - Awb:
> > +  - BlackLevelCorrection:
>
> BLC without a vlaue will assume 256. If we want to merge this I would
> prefer to have the actual black level value measured.
>
> If you agree I can remove it when applying the patch

Do I understand correctly that with default values, BLC actually does
nothing to the image? In such case, it is not needed.

>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>
>
> > +  - ColorProcessing:
> > +...
> > --
> > 2.39.2
> >

Best regards
Daniel

Hi Daniel

On Tue, Apr 04, 2023 at 12:00:57PM +0200, Daniel Semkowicz wrote:
> Hi Jacopo,
>
> On Mon, Apr 3, 2023 at 2:37 PM Jacopo Mondi
> <jacopo.mondi@ideasonboard.com> wrote:
> >
> > Hi Daniel
> >
> > On Fri, Mar 31, 2023 at 10:19:30AM +0200, Daniel Semkowicz via libcamera-devel wrote:
> > > Add the OV5675 tuning file with default values and enabled AF algorithm.
> > >
> > > Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
> > > ---
> > >  src/ipa/rkisp1/data/meson.build |  1 +
> > >  src/ipa/rkisp1/data/ov5675.yaml | 18 ++++++++++++++++++
> > >  2 files changed, 19 insertions(+)
> > >  create mode 100644 src/ipa/rkisp1/data/ov5675.yaml
> > >
> > > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
> > > index f5e9fa75..1fdce2c9 100644
> > > --- a/src/ipa/rkisp1/data/meson.build
> > > +++ b/src/ipa/rkisp1/data/meson.build
> > > @@ -4,6 +4,7 @@ conf_files = files([
> > >      'imx219.yaml',
> > >      'ov4689.yaml',
> > >      'ov5640.yaml',
> > > +    'ov5675.yaml',
> > >      'uncalibrated.yaml',
> > >  ])
> > >
> > > diff --git a/src/ipa/rkisp1/data/ov5675.yaml b/src/ipa/rkisp1/data/ov5675.yaml
> > > new file mode 100644
> > > index 00000000..4f3da897
> > > --- /dev/null
> > > +++ b/src/ipa/rkisp1/data/ov5675.yaml
> > > @@ -0,0 +1,18 @@
> > > +# SPDX-License-Identifier: CC0-1.0
> > > +%YAML 1.1
> > > +---
> > > +version: 1
> > > +algorithms:
> > > +  - Af:
> > > +      coarse-search-step: 30
> > > +      fine-search-step: 1
> > > +      fine-search-range: 5
> > > +      max-variance-change: 0.5
> > > +      wait-frames-lens: 2 # tuned for 30fps stream
> > > +      isp-threshold: 128
> > > +      isp-var-shift: 4
> > > +  - Agc:
> > > +  - Awb:
> > > +  - BlackLevelCorrection:
> >
> > BLC without a vlaue will assume 256. If we want to merge this I would
> > prefer to have the actual black level value measured.
> >
> > If you agree I can remove it when applying the patch
>
> Do I understand correctly that with default values, BLC actually does
> nothing to the image? In such case, it is not needed.
>

If I read it right, if no correction value is provided in the
configuration file the algorithms assumes 256 as correction value to
subtract to all pixels.

I would prefer if BLC is enabled to have the actual sensor black level
measured. Otherwise better leave it out (from mainline at least).

> >
> > Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> >
> >
> > > +  - ColorProcessing:
> > > +...
> > > --
> > > 2.39.2
> > >
>
> Best regards
> Daniel