[libcamera-devel,v2,2/3] doc: gstreamer: Add missing queues
diff mbox series

Message ID 20230324181247.302586-3-nicolas@ndufresne.ca
State Accepted
Headers show
Series
  • Add sensor mode selection to GStreamer
Related show

Commit Message

Nicolas Dufresne March 24, 2023, 6:12 p.m. UTC
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>

As libcamerasrc reports some latency, a queue is needed in order to store the
data in case the buffers has been produced slightly ahead of our reported
latency.

Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
---
 README.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Nicolas Dufresne March 27, 2023, 1:42 p.m. UTC | #1
Le vendredi 24 mars 2023 à 14:12 -0400, Nicolas Dufresne a écrit :
> From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> 
> As libcamerasrc reports some latency, a queue is needed in order to store the
> data in case the buffers has been produced slightly ahead of our reported
> latency.

It could be nice to consider this patch independent from the rest. Currently,
unless your camera has less then a frame of latency, the GStreamer pipeline emit
a warning, and you can also notice quite some jitter.

> 
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
>  README.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index 34b6b49f..52cde91c 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -133,7 +133,7 @@ onto the OpenGL accelerated display element on your system.
>  
>  .. code::
>  
> -  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! glimagesink
> +  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! queue ! glimagesink
>  
>  To show the first camera found you can omit the camera-name property, or you
>  can list the cameras and their capabilities using:
> @@ -164,7 +164,7 @@ the following example could be used as a starting point:
>  
>     gst-launch-1.0 libcamerasrc ! \
>          video/x-raw,colorimetry=bt709,format=NV12,width=1280,height=720,framerate=30/1 ! \
> -        jpegenc ! multipartmux ! \
> +        queue ! jpegenc ! multipartmux ! \
>          tcpserversink host=0.0.0.0 port=5000
>  
>  Which can be received on another device over the network with:
Jacopo Mondi March 27, 2023, 3:27 p.m. UTC | #2
Hi Nicolas

On Fri, Mar 24, 2023 at 02:12:46PM -0400, Nicolas Dufresne via libcamera-devel wrote:
> From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
>
> As libcamerasrc reports some latency, a queue is needed in order to store the
> data in case the buffers has been produced slightly ahead of our reported
> latency.
>
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

I think we can take this is outside of the larger series in discussion

> ---
>  README.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/README.rst b/README.rst
> index 34b6b49f..52cde91c 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -133,7 +133,7 @@ onto the OpenGL accelerated display element on your system.
>
>  .. code::
>
> -  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! glimagesink
> +  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! queue ! glimagesink
>
>  To show the first camera found you can omit the camera-name property, or you
>  can list the cameras and their capabilities using:
> @@ -164,7 +164,7 @@ the following example could be used as a starting point:
>
>     gst-launch-1.0 libcamerasrc ! \
>          video/x-raw,colorimetry=bt709,format=NV12,width=1280,height=720,framerate=30/1 ! \
> -        jpegenc ! multipartmux ! \
> +        queue ! jpegenc ! multipartmux ! \
>          tcpserversink host=0.0.0.0 port=5000
>
>  Which can be received on another device over the network with:
> --
> 2.39.2
>

Patch
diff mbox series

diff --git a/README.rst b/README.rst
index 34b6b49f..52cde91c 100644
--- a/README.rst
+++ b/README.rst
@@ -133,7 +133,7 @@  onto the OpenGL accelerated display element on your system.
 
 .. code::
 
-  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! glimagesink
+  gst-launch-1.0 libcamerasrc camera-name="Camera 1" ! queue ! glimagesink
 
 To show the first camera found you can omit the camera-name property, or you
 can list the cameras and their capabilities using:
@@ -164,7 +164,7 @@  the following example could be used as a starting point:
 
    gst-launch-1.0 libcamerasrc ! \
         video/x-raw,colorimetry=bt709,format=NV12,width=1280,height=720,framerate=30/1 ! \
-        jpegenc ! multipartmux ! \
+        queue ! jpegenc ! multipartmux ! \
         tcpserversink host=0.0.0.0 port=5000
 
 Which can be received on another device over the network with: