| Message ID | 20221019135747.25307-1-naush@raspberrypi.com |
|---|---|
| State | Accepted |
| Commit | 6b9049de1f12fca108c0affe29923a5427a9fb02 |
| Headers | show |
| Series |
|
| Related | show |
Hi Naush, Thank you for the patch. On Wed, Oct 19, 2022 at 02:57:47PM +0100, Naushir Patuck via libcamera-devel wrote: > The recent change to the naming scheme for the camera tuning files failed to > rename ov9281.json, causing the sensor to fail to load. Since this is a mono > sensor module, rename this file to ov9281_mono.json. > > Fixes: 820607b195ff: ("pipeline: raspberrypi: Update naming convention for tuning files") > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/ipa/raspberrypi/data/meson.build | 2 +- > src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} (100%) > > diff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/raspberrypi/data/meson.build > index 6c5beb0e0f67..84c1dabbec9c 100644 > --- a/src/ipa/raspberrypi/data/meson.build > +++ b/src/ipa/raspberrypi/data/meson.build > @@ -12,7 +12,7 @@ conf_files = files([ > 'imx519.json', > 'ov5647.json', > 'ov5647_noir.json', > - 'ov9281.json', > + 'ov9281_mono.json', > 'se327m12.json', > 'uncalibrated.json', > ]) > diff --git a/src/ipa/raspberrypi/data/ov9281.json b/src/ipa/raspberrypi/data/ov9281_mono.json > similarity index 100% > rename from src/ipa/raspberrypi/data/ov9281.json > rename to src/ipa/raspberrypi/data/ov9281_mono.json
Hi Naush Thanks for fixing this! On Wed, 19 Oct 2022 at 22:07, Laurent Pinchart via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote: > > Hi Naush, > > Thank you for the patch. > > On Wed, Oct 19, 2022 at 02:57:47PM +0100, Naushir Patuck via libcamera-devel wrote: > > The recent change to the naming scheme for the camera tuning files failed to > > rename ov9281.json, causing the sensor to fail to load. Since this is a mono > > sensor module, rename this file to ov9281_mono.json. > > > > Fixes: 820607b195ff: ("pipeline: raspberrypi: Update naming convention for tuning files") > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Thanks! David > > > --- > > src/ipa/raspberrypi/data/meson.build | 2 +- > > src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} | 0 > > 2 files changed, 1 insertion(+), 1 deletion(-) > > rename src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} (100%) > > > > diff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/raspberrypi/data/meson.build > > index 6c5beb0e0f67..84c1dabbec9c 100644 > > --- a/src/ipa/raspberrypi/data/meson.build > > +++ b/src/ipa/raspberrypi/data/meson.build > > @@ -12,7 +12,7 @@ conf_files = files([ > > 'imx519.json', > > 'ov5647.json', > > 'ov5647_noir.json', > > - 'ov9281.json', > > + 'ov9281_mono.json', > > 'se327m12.json', > > 'uncalibrated.json', > > ]) > > diff --git a/src/ipa/raspberrypi/data/ov9281.json b/src/ipa/raspberrypi/data/ov9281_mono.json > > similarity index 100% > > rename from src/ipa/raspberrypi/data/ov9281.json > > rename to src/ipa/raspberrypi/data/ov9281_mono.json > > -- > Regards, > > Laurent Pinchart
diff --git a/src/ipa/raspberrypi/data/meson.build b/src/ipa/raspberrypi/data/meson.build index 6c5beb0e0f67..84c1dabbec9c 100644 --- a/src/ipa/raspberrypi/data/meson.build +++ b/src/ipa/raspberrypi/data/meson.build @@ -12,7 +12,7 @@ conf_files = files([ 'imx519.json', 'ov5647.json', 'ov5647_noir.json', - 'ov9281.json', + 'ov9281_mono.json', 'se327m12.json', 'uncalibrated.json', ]) diff --git a/src/ipa/raspberrypi/data/ov9281.json b/src/ipa/raspberrypi/data/ov9281_mono.json similarity index 100% rename from src/ipa/raspberrypi/data/ov9281.json rename to src/ipa/raspberrypi/data/ov9281_mono.json
The recent change to the naming scheme for the camera tuning files failed to rename ov9281.json, causing the sensor to fail to load. Since this is a mono sensor module, rename this file to ov9281_mono.json. Fixes: 820607b195ff: ("pipeline: raspberrypi: Update naming convention for tuning files") Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/ipa/raspberrypi/data/meson.build | 2 +- src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename src/ipa/raspberrypi/data/{ov9281.json => ov9281_mono.json} (100%)