[libcamera-devel,v2,0/2] Raspberry Pi: Timeout error handling
mbox series

Message ID 20220921080258.5268-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi: Timeout error handling
Related show

Message

Naushir Patuck Sept. 21, 2022, 8:02 a.m. UTC 
Hi,

Minor changes in version 2:
- Fixed a typo.
- Added an isRunning() helper to check the pipeline handler state.

Regards,
Naush

Naushir Patuck (2):
  pipeline: raspberrypi: Add an error state
  pipeline: raspberrypi: Improve Unicam timeout handling

 .../pipeline/raspberrypi/raspberrypi.cpp      | 33 ++++++++++++++-----
 1 file changed, 25 insertions(+), 8 deletions(-)

Comments

Naushir Patuck Sept. 23, 2022, 8:15 a.m. UTC | #1 
Hi all,

Any chance I can get a second review on this change please?

regards,
Naush

On Wed, 21 Sept 2022 at 09:03, Naushir Patuck <naush@raspberrypi.com> wrote:

> Hi,
>
> Minor changes in version 2:
> - Fixed a typo.
> - Added an isRunning() helper to check the pipeline handler state.
>
> Regards,
> Naush
>
> Naushir Patuck (2):
>   pipeline: raspberrypi: Add an error state
>   pipeline: raspberrypi: Improve Unicam timeout handling
>
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 33 ++++++++++++++-----
>  1 file changed, 25 insertions(+), 8 deletions(-)
>
> --
> 2.25.1
>
>
Kieran Bingham Sept. 23, 2022, 12:03 p.m. UTC | #2 
Quoting Naushir Patuck via libcamera-devel (2022-09-23 09:15:21)
> Hi all,
> 
> Any chance I can get a second review on this change please?

Pushed with David's review.

Thanks

Kieran


> 
> regards,
> Naush
> 
> On Wed, 21 Sept 2022 at 09:03, Naushir Patuck <naush@raspberrypi.com> wrote:
> 
> > Hi,
> >
> > Minor changes in version 2:
> > - Fixed a typo.
> > - Added an isRunning() helper to check the pipeline handler state.
> >
> > Regards,
> > Naush
> >
> > Naushir Patuck (2):
> >   pipeline: raspberrypi: Add an error state
> >   pipeline: raspberrypi: Improve Unicam timeout handling
> >
> >  .../pipeline/raspberrypi/raspberrypi.cpp      | 33 ++++++++++++++-----
> >  1 file changed, 25 insertions(+), 8 deletions(-)
> >
> > --
> > 2.25.1
> >
> >