[libcamera-devel,v2,2/4] ipa: rkisp1: Transfer queueRequest() call to each algorithm
diff mbox series

Message ID 20220720154221.50937-3-fsylvestre@baylibre.com
State Accepted
Headers show
Series
  • Add Demosaicing and Color Processing control for rkisp1
Related show

Commit Message

Florian Sylvestre July 20, 2022, 3:42 p.m. UTC 
Implement rkisp1 queueRequest() function to update each algorithm with user
controls.

Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/rkisp1/rkisp1.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Nicolas Dufresne via libcamera-devel July 21, 2022, 7:43 a.m. UTC | #1 
Hi Florian,

On Wed, Jul 20, 2022 at 05:42:19PM +0200, Florian Sylvestre via libcamera-devel wrote:
> Implement rkisp1 queueRequest() function to update each algorithm with user
> controls.
> 
> Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/ipa/rkisp1/rkisp1.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index a32bb9d1..34034526 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -269,10 +269,10 @@ void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)
>  	}
>  }
>  
> -void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,
> -			     [[maybe_unused]] const ControlList &controls)
> +void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)
>  {
> -	/* \todo Start processing for 'frame' based on 'controls'. */
> +	for (auto const &algo : algorithms())
> +		algo->queueRequest(context_, frame, controls);
>  }
>  
>  void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)
> -- 
> 2.34.1
>
Kieran Bingham July 21, 2022, 12:53 p.m. UTC | #2 
Quoting Florian Sylvestre via libcamera-devel (2022-07-20 16:42:19)
> Implement rkisp1 queueRequest() function to update each algorithm with user
> controls.
> 
> Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I've also picked this into my development branch, but adjusted it for
passing the FrameContext.

But I don't mind rebasing on top of this if it goes in first.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  src/ipa/rkisp1/rkisp1.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index a32bb9d1..34034526 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -269,10 +269,10 @@ void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)
>         }
>  }
>  
> -void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,
> -                            [[maybe_unused]] const ControlList &controls)
> +void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)
>  {
> -       /* \todo Start processing for 'frame' based on 'controls'. */
> +       for (auto const &algo : algorithms())
> +               algo->queueRequest(context_, frame, controls);
>  }
>  
>  void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)
> -- 
> 2.34.1
>

Patch
diff mbox series 

diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
index a32bb9d1..34034526 100644
--- a/src/ipa/rkisp1/rkisp1.cpp
+++ b/src/ipa/rkisp1/rkisp1.cpp
@@ -269,10 +269,10 @@  void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)
 	}
 }
 
-void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,
-			     [[maybe_unused]] const ControlList &controls)
+void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)
 {
-	/* \todo Start processing for 'frame' based on 'controls'. */
+	for (auto const &algo : algorithms())
+		algo->queueRequest(context_, frame, controls);
 }
 
 void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)