| Message ID | 20220617092315.120781-5-fsylvestre@baylibre.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Florian, Thank you for the patch. On Fri, Jun 17, 2022 at 11:23:14AM +0200, Florian Sylvestre wrote: > Add the ov5640 tuning file containing default values for 'black level > correction' algorithm. > > Signed-off-by: Florian Sylvestre <fsylvestre@baylibre.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> > --- > src/ipa/rkisp1/data/meson.build | 8 ++++++++ > src/ipa/rkisp1/data/ov5640.yaml | 10 ++++++++++ > src/ipa/rkisp1/meson.build | 1 + > 3 files changed, 19 insertions(+) > create mode 100644 src/ipa/rkisp1/data/meson.build > create mode 100644 src/ipa/rkisp1/data/ov5640.yaml > > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build > new file mode 100644 > index 00000000..2656bb2e > --- /dev/null > +++ b/src/ipa/rkisp1/data/meson.build > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: CC0-1.0 > + > +conf_files = files([ > + 'ov5640.yaml', > +]) > + > +install_data(conf_files, > + install_dir : ipa_data_dir / 'rkisp1') > diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml > new file mode 100644 > index 00000000..c4eda49b > --- /dev/null > +++ b/src/ipa/rkisp1/data/ov5640.yaml > @@ -0,0 +1,10 @@ > +# SPDX-License-Identifier: CC0-1.0 %YAML 1.2 > +--- > +version: 1 > +algorithms: > + - BlackLevelCorrection: > + R: 256 You need one more indentation level here: algorithms: - BlackLevelCorrection: R: 256 Otherwise the data would translate (in JSON form) to { "version": 1, "algorithms": [ { "BlackLevelCorrection": "", "R": 256, "Gr": 256, "Gb": 256, "B": 256, } ] } while the correct structure is { "version": 1, "algorithms": [ { "BlackLevelCorrection": { "R": 256, "Gr": 256, "Gb": 256, "B": 256, } } ] } > + Gr: 256 > + Gb: 256 > + B: 256 > +... > diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build > index 8c822fbb..ccb84b27 100644 > --- a/src/ipa/rkisp1/meson.build > +++ b/src/ipa/rkisp1/meson.build > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: CC0-1.0 > > subdir('algorithms') > +subdir('data') > > ipa_name = 'ipa_rkisp1' >
diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build new file mode 100644 index 00000000..2656bb2e --- /dev/null +++ b/src/ipa/rkisp1/data/meson.build @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: CC0-1.0 + +conf_files = files([ + 'ov5640.yaml', +]) + +install_data(conf_files, + install_dir : ipa_data_dir / 'rkisp1') diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml new file mode 100644 index 00000000..c4eda49b --- /dev/null +++ b/src/ipa/rkisp1/data/ov5640.yaml @@ -0,0 +1,10 @@ +# SPDX-License-Identifier: CC0-1.0 +--- +version: 1 +algorithms: + - BlackLevelCorrection: + R: 256 + Gr: 256 + Gb: 256 + B: 256 +... diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build index 8c822fbb..ccb84b27 100644 --- a/src/ipa/rkisp1/meson.build +++ b/src/ipa/rkisp1/meson.build @@ -1,6 +1,7 @@ # SPDX-License-Identifier: CC0-1.0 subdir('algorithms') +subdir('data') ipa_name = 'ipa_rkisp1'