[libcamera-devel,v2,0/5] libcamera: pipeline: simple: Support scaling on the camea sensor
mbox series

Message ID 20220612152311.8408-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: pipeline: simple: Support scaling on the camea sensor
Related show

Message

Laurent Pinchart June 12, 2022, 3:23 p.m. UTC
Hello,

This patch series improves the simple pipeline handler to support
scaling (in the generic sense, this can be binning/skipping or real
scaling) on the camera sensor in addition to the converter. This is
useful on platforms that don't have a converter, but also on platforms
where the SoC camera pipeline has limitations on resolution and/or
bandwidth.

Patches 1/5 and 2/5 are small drive-by improvements, patches 3/5 and 4/5
prepare for sensor scaling support with some code refactoring, and patch
5/5 then performs the bulk of the work, with an explanation of the
heuristics used to configure scaling.

Laurent Pinchart (5):
  libcamera: pipeline: simple: Improve debug message on config failure
  libcamera: pipeline: simple: Document the pipeline traversal algorithm
  libcamera: pipeline: simple: Factor out format test to separate
    function
  libcamera: pipeline: simple: Store sensor resolution in configuration
  libcamera: pipeline: simple: Support scaling on the sensor

 src/libcamera/pipeline/simple/simple.cpp | 270 ++++++++++++++++-------
 1 file changed, 190 insertions(+), 80 deletions(-)


base-commit: b4d4b78c82a23de3c6dd1676bf43bba1d6043652

Comments

Dorota Czaplejewicz June 13, 2022, 9:11 a.m. UTC | #1
On Sun, 12 Jun 2022 18:23:06 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:

> Hello,
> 
> This patch series improves the simple pipeline handler to support
> scaling (in the generic sense, this can be binning/skipping or real
> scaling) on the camera sensor in addition to the converter. This is
> useful on platforms that don't have a converter, but also on platforms
> where the SoC camera pipeline has limitations on resolution and/or
> bandwidth.
> 
> Patches 1/5 and 2/5 are small drive-by improvements, patches 3/5 and 4/5
> prepare for sensor scaling support with some code refactoring, and patch
> 5/5 then performs the bulk of the work, with an explanation of the
> heuristics used to configure scaling.
> 
> Laurent Pinchart (5):
>   libcamera: pipeline: simple: Improve debug message on config failure
>   libcamera: pipeline: simple: Document the pipeline traversal algorithm
>   libcamera: pipeline: simple: Factor out format test to separate
>     function
>   libcamera: pipeline: simple: Store sensor resolution in configuration
>   libcamera: pipeline: simple: Support scaling on the sensor
> 
>  src/libcamera/pipeline/simple/simple.cpp | 270 ++++++++++++++++-------
>  1 file changed, 190 insertions(+), 80 deletions(-)
> 
> 
> base-commit: b4d4b78c82a23de3c6dd1676bf43bba1d6043652

Tested-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
Reviewed-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>