| Message ID | 20220507133039.30327-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | c70323e4941542202c34f4fde7d340d1f62d6c9c |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, On 5/7/22 19:00, Laurent Pinchart via libcamera-devel wrote: > The message that prints all controls in a request in > IPARPi::queueRequest() is noisy. Demote it from Info to Debug. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/ipa/raspberrypi/raspberrypi.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp > index 5efd051bdd13..05dc626aa90b 100644 > --- a/src/ipa/raspberrypi/raspberrypi.cpp > +++ b/src/ipa/raspberrypi/raspberrypi.cpp > @@ -632,9 +632,9 @@ void IPARPi::queueRequest(const ControlList &controls) > libcameraMetadata_.clear(); > > for (auto const &ctrl : controls) { > - LOG(IPARPI, Info) << "Request ctrl: " > - << controls::controls.at(ctrl.first)->name() > - << " = " << ctrl.second.toString(); > + LOG(IPARPI, Debug) << "Request ctrl: " > + << controls::controls.at(ctrl.first)->name() > + << " = " << ctrl.second.toString(); Makes sense, Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > > switch (ctrl.first) { > case controls::AE_ENABLE: { > > base-commit: 1e4c4ad5f78ad7abc73854646f6e9902dc3c1925
Hi Laurent, Thank you for your patch. On Sat, 7 May 2022 at 14:30, Laurent Pinchart < laurent.pinchart@ideasonboard.com> wrote: > The message that prints all controls in a request in > IPARPi::queueRequest() is noisy. Demote it from Info to Debug. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Naushir Patuck <naush@raspberrypi.com> > --- > src/ipa/raspberrypi/raspberrypi.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp > b/src/ipa/raspberrypi/raspberrypi.cpp > index 5efd051bdd13..05dc626aa90b 100644 > --- a/src/ipa/raspberrypi/raspberrypi.cpp > +++ b/src/ipa/raspberrypi/raspberrypi.cpp > @@ -632,9 +632,9 @@ void IPARPi::queueRequest(const ControlList &controls) > libcameraMetadata_.clear(); > > for (auto const &ctrl : controls) { > - LOG(IPARPI, Info) << "Request ctrl: " > - << controls::controls.at > (ctrl.first)->name() > - << " = " << ctrl.second.toString(); > + LOG(IPARPI, Debug) << "Request ctrl: " > + << controls::controls.at > (ctrl.first)->name() > + << " = " << ctrl.second.toString(); > > switch (ctrl.first) { > case controls::AE_ENABLE: { > > base-commit: 1e4c4ad5f78ad7abc73854646f6e9902dc3c1925 > -- > Regards, > > Laurent Pinchart > >
diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 5efd051bdd13..05dc626aa90b 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -632,9 +632,9 @@ void IPARPi::queueRequest(const ControlList &controls) libcameraMetadata_.clear(); for (auto const &ctrl : controls) { - LOG(IPARPI, Info) << "Request ctrl: " - << controls::controls.at(ctrl.first)->name() - << " = " << ctrl.second.toString(); + LOG(IPARPI, Debug) << "Request ctrl: " + << controls::controls.at(ctrl.first)->name() + << " = " << ctrl.second.toString(); switch (ctrl.first) { case controls::AE_ENABLE: {
The message that prints all controls in a request in IPARPi::queueRequest() is noisy. Demote it from Info to Debug. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/ipa/raspberrypi/raspberrypi.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: 1e4c4ad5f78ad7abc73854646f6e9902dc3c1925