[libcamera-devel] libcamera: Require gcc 8 or newer

15370 diff mbox series

gcc 7 has reached end of life and isn't used as a default compiler by
any of the major distributions. It has also been dropped from buildroot.
Drop its support in libcamera.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 meson.build | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Hi Laurent,

Quoting Laurent Pinchart (2022-02-21 13:58:47)
> gcc 7 has reached end of life and isn't used as a default compiler by
> any of the major distributions. It has also been dropped from buildroot.
> Drop its support in libcamera.
> 

Reducing outdated toolchains sounds good to me. Particularly as GCC-7
isn't even in my compile-test-matrix.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  meson.build | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 9684d562828d..29d8542dada2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -81,11 +81,11 @@ if cc.get_id() == 'clang'
>  endif
>  
>  if cc.get_id() == 'gcc'
> -    if cc.version().version_compare('<7')
> -        error('gcc version is too old, libcamera requires 7.0 or newer')
> +    if cc.version().version_compare('<8')
> +        error('gcc version is too old, libcamera requires 8.0 or newer')
>      endif
>  
> -    # On gcc 7 and 8, the file system library is provided in a separate static
> +    # On gcc 8, the file system library is provided in a separate static
>      # library.
>      if cc.version().version_compare('<9')
>          cpp_arguments += [
> @@ -95,9 +95,8 @@ if cc.get_id() == 'gcc'
>  
>      # gcc 7.1 introduced processor-specific ABI breakages related to parameter
>      # passing on ARM platforms. This generates a large number of messages
> -    # during compilation with gcc >=7.1. Silence them.
> -    if (host_machine.cpu_family() == 'arm' and
> -        cc.version().version_compare('>=7.1'))
> +    # during compilation. Silence them.
> +    if host_machine.cpu_family() == 'arm'
>          cpp_arguments += [
>              '-Wno-psabi',
>          ]
> -- 
> Regards,
> 
> Laurent Pinchart
>

Hi Laurent,

On Mon, Feb 21, 2022 at 03:58:47PM +0200, Laurent Pinchart wrote:
> gcc 7 has reached end of life and isn't used as a default compiler by
> any of the major distributions. It has also been dropped from buildroot.
> Drop its support in libcamera.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  meson.build | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 9684d562828d..29d8542dada2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -81,11 +81,11 @@ if cc.get_id() == 'clang'
>  endif
>  
>  if cc.get_id() == 'gcc'
> -    if cc.version().version_compare('<7')
> -        error('gcc version is too old, libcamera requires 7.0 or newer')
> +    if cc.version().version_compare('<8')
> +        error('gcc version is too old, libcamera requires 8.0 or newer')
>      endif
>  
> -    # On gcc 7 and 8, the file system library is provided in a separate static
> +    # On gcc 8, the file system library is provided in a separate static
>      # library.
>      if cc.version().version_compare('<9')
>          cpp_arguments += [
> @@ -95,9 +95,8 @@ if cc.get_id() == 'gcc'
>  
>      # gcc 7.1 introduced processor-specific ABI breakages related to parameter
>      # passing on ARM platforms. This generates a large number of messages
> -    # during compilation with gcc >=7.1. Silence them.
> -    if (host_machine.cpu_family() == 'arm' and
> -        cc.version().version_compare('>=7.1'))
> +    # during compilation. Silence them.
> +    if host_machine.cpu_family() == 'arm'
>          cpp_arguments += [
>              '-Wno-psabi',
>          ]