[libcamera-devel,v2,11/12] test: camera: Fix trivial spelling mistaken
diff mbox series

Message ID 20211120111313.106621-12-jacopo@jmondi.org
State Superseded
Headers show
Series
  • libcamera: Add support for Fence
Related show

Commit Message

Jacopo Mondi Nov. 20, 2021, 11:13 a.m. UTC
The error message should be:
"Failed to associate buffer with request"

Fix that.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 test/camera/capture.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart Nov. 21, 2021, 6:37 p.m. UTC | #1
Hi Jacopo,

Thank you for the patch.

On Sat, Nov 20, 2021 at 12:13:12PM +0100, Jacopo Mondi wrote:
> The error message should be:
> "Failed to associate buffer with request"
> 
> Fix that.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Please fast-track this.

> ---
>  test/camera/capture.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp
> index 41ae00d7a4c0..f3824f95cbd3 100644
> --- a/test/camera/capture.cpp
> +++ b/test/camera/capture.cpp
> @@ -109,7 +109,7 @@ protected:
>  			}
>  
>  			if (request->addBuffer(stream, buffer.get())) {
> -				cout << "Failed to associating buffer with request" << endl;
> +				cout << "Failed to associate buffer with request" << endl;
>  				return TestFail;
>  			}
>
Kieran Bingham Nov. 29, 2021, 5:03 p.m. UTC | #2
Quoting Laurent Pinchart (2021-11-21 18:37:37)
> Hi Jacopo,
> 
> Thank you for the patch.
> 
> On Sat, Nov 20, 2021 at 12:13:12PM +0100, Jacopo Mondi wrote:
> > The error message should be:
> > "Failed to associate buffer with request"
> > 
> > Fix that.
> > 
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Please fast-track this.

To fast-tracken this, pleasen removen the n from mistaken.
(in $SUBJECT)

And thenen:

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> > ---
> >  test/camera/capture.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp
> > index 41ae00d7a4c0..f3824f95cbd3 100644
> > --- a/test/camera/capture.cpp
> > +++ b/test/camera/capture.cpp
> > @@ -109,7 +109,7 @@ protected:
> >                       }
> >  
> >                       if (request->addBuffer(stream, buffer.get())) {
> > -                             cout << "Failed to associating buffer with request" << endl;
> > +                             cout << "Failed to associate buffer with request" << endl;
> >                               return TestFail;
> >                       }
> >  
> 
> -- 
> Regards,
> 
> Laurent Pinchart

Patch
diff mbox series

diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp
index 41ae00d7a4c0..f3824f95cbd3 100644
--- a/test/camera/capture.cpp
+++ b/test/camera/capture.cpp
@@ -109,7 +109,7 @@  protected:
 			}
 
 			if (request->addBuffer(stream, buffer.get())) {
-				cout << "Failed to associating buffer with request" << endl;
+				cout << "Failed to associate buffer with request" << endl;
 				return TestFail;
 			}