[libcamera-devel] libcamera: camera_manager: Fix utils.h #include location
diff mbox series

Message ID 20210924150339.18835-1-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel] libcamera: camera_manager: Fix utils.h #include location
Related show

Commit Message

Laurent Pinchart Sept. 24, 2021, 3:03 p.m. UTC 
The utils.h header #include is separate from the rest of the group for
no reason. Move it to where it should be.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/camera_manager.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


base-commit: 40f5fddca7f774944a53f58eeaebc4db79c373d8

Comments

Kieran Bingham Sept. 24, 2021, 3:25 p.m. UTC | #1 
On 24/09/2021 16:03, Laurent Pinchart wrote:
> The utils.h header #include is separate from the rest of the group for
> no reason. Move it to where it should be.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> ---
>  src/libcamera/camera_manager.cpp | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
> index e7d026ae94c8..43bfa2b72a51 100644
> --- a/src/libcamera/camera_manager.cpp
> +++ b/src/libcamera/camera_manager.cpp
> @@ -12,10 +12,9 @@
>  
>  #include <libcamera/camera.h>
>  
> -#include <libcamera/base/utils.h>
> -
>  #include <libcamera/base/log.h>
>  #include <libcamera/base/thread.h>
> +#include <libcamera/base/utils.h>
>  
>  #include "libcamera/internal/device_enumerator.h"
>  #include "libcamera/internal/ipa_manager.h"
> 
> base-commit: 40f5fddca7f774944a53f58eeaebc4db79c373d8
>
Umang Jain Sept. 25, 2021, 3:59 a.m. UTC | #2 
Hi Laurent,

On 9/24/21 8:33 PM, Laurent Pinchart wrote:
> The utils.h header #include is separate from the rest of the group for
> no reason. Move it to where it should be.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

> ---
>   src/libcamera/camera_manager.cpp | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
> index e7d026ae94c8..43bfa2b72a51 100644
> --- a/src/libcamera/camera_manager.cpp
> +++ b/src/libcamera/camera_manager.cpp
> @@ -12,10 +12,9 @@
>   
>   #include <libcamera/camera.h>
>   
> -#include <libcamera/base/utils.h>
> -
>   #include <libcamera/base/log.h>
>   #include <libcamera/base/thread.h>
> +#include <libcamera/base/utils.h>
>   
>   #include "libcamera/internal/device_enumerator.h"
>   #include "libcamera/internal/ipa_manager.h"
>
> base-commit: 40f5fddca7f774944a53f58eeaebc4db79c373d8

Patch
diff mbox series 

diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
index e7d026ae94c8..43bfa2b72a51 100644
--- a/src/libcamera/camera_manager.cpp
+++ b/src/libcamera/camera_manager.cpp
@@ -12,10 +12,9 @@ 
 
 #include <libcamera/camera.h>
 
-#include <libcamera/base/utils.h>
-
 #include <libcamera/base/log.h>
 #include <libcamera/base/thread.h>
+#include <libcamera/base/utils.h>
 
 #include "libcamera/internal/device_enumerator.h"
 #include "libcamera/internal/ipa_manager.h"