[libcamera-devel,5/9] libcamera: device_enumerator: Fix wording of log message
diff mbox series

Message ID 20190103013110.6849-5-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel,1/9] libcamera: camera_manager: Remove put() method
Related show

Commit Message

Laurent Pinchart Jan. 3, 2019, 1:31 a.m. UTC 
The log message still refers to the DeviceInfo class that has been
removed. Replace it with a reference to MediaDevice.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/device_enumerator.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Niklas Söderlund Jan. 3, 2019, 9:22 p.m. UTC | #1 
Hi Laurent,

Thanks for your work.

On 2019-01-03 03:31:06 +0200, Laurent Pinchart wrote:
> The log message still refers to the DeviceInfo class that has been
> removed. Replace it with a reference to MediaDevice.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/device_enumerator.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp
> index bc55a12f2a4e..ecd51bc1d108 100644
> --- a/src/libcamera/device_enumerator.cpp
> +++ b/src/libcamera/device_enumerator.cpp
> @@ -153,7 +153,7 @@ DeviceEnumerator::~DeviceEnumerator()
>  {
>  	for (MediaDevice *dev : devices_) {
>  		if (dev->busy())
> -			LOG(Error) << "Removing device info while still in use";
> +			LOG(Error) << "Removing media device while still in use";
>  
>  		delete dev;
>  	}
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch
diff mbox series 

diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp
index bc55a12f2a4e..ecd51bc1d108 100644
--- a/src/libcamera/device_enumerator.cpp
+++ b/src/libcamera/device_enumerator.cpp
@@ -153,7 +153,7 @@  DeviceEnumerator::~DeviceEnumerator()
 {
 	for (MediaDevice *dev : devices_) {
 		if (dev->busy())
-			LOG(Error) << "Removing device info while still in use";
+			LOG(Error) << "Removing media device while still in use";
 
 		delete dev;
 	}