[libcamera-devel] ipa: libipa: histogram: Fix typo
diff mbox series

Message ID 20210831091800.22682-1-laurent.pinchart@ideasonboard.com
State Accepted
Commit 2e4fc65f77309fd99225ab0b40c123f92eba13a8
Headers show
Series
  • [libcamera-devel] ipa: libipa: histogram: Fix typo
Related show

Commit Message

Laurent Pinchart Aug. 31, 2021, 9:18 a.m. UTC
"weighted", derived from the verb "to weight", comes from Middle English
weight, weiȝte, weght, wight, from Old English wiht, ġewiht, from
Proto-Germanic *wihtiz, from Proto-Indo-European *weǵʰ-. In none of
those does the t come before the h.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/ipa/libipa/histogram.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Aug. 31, 2021, 9:19 a.m. UTC | #1
On 31/08/2021 10:18, Laurent Pinchart wrote:
> "weighted", derived from the verb "to weight", comes from Middle English
> weight, weiȝte, weght, wight, from Old English wiht, ġewiht, from
> Proto-Germanic *wihtiz, from Proto-Indo-European *weǵʰ-. In none of
> those does the t come before the h.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  src/ipa/libipa/histogram.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp
> index fb1eb2a2f0b1..4d94571f903a 100644
> --- a/src/ipa/libipa/histogram.cpp
> +++ b/src/ipa/libipa/histogram.cpp
> @@ -139,7 +139,7 @@ double Histogram::interQuantileMean(double lowQuantile, double highQuantile) con
>  		double freq = (cumulative_[bin + 1] - cumulative_[bin])
>  			* (std::min(p_next, highPoint) - lowPoint);
>  
> -		/* Accumulate weigthed bin */
> +		/* Accumulate weighted bin */
>  		sumBinFreq += bin * freq;
>  		/* Accumulate weights */
>  		cumulFreq += freq;
>
Jean-Michel Hautbois Aug. 31, 2021, 9:34 a.m. UTC | #2
Hi Laurent,

On 31/08/2021 11:19, Kieran Bingham wrote:
> On 31/08/2021 10:18, Laurent Pinchart wrote:
>> "weighted", derived from the verb "to weight", comes from Middle English
>> weight, weiȝte, weght, wight, from Old English wiht, ġewiht, from
>> Proto-Germanic *wihtiz, from Proto-Indo-European *weǵʰ-. In none of
>> those does the t come before the h.
> 
> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> 
> 
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> ---
>>  src/ipa/libipa/histogram.cpp | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp
>> index fb1eb2a2f0b1..4d94571f903a 100644
>> --- a/src/ipa/libipa/histogram.cpp
>> +++ b/src/ipa/libipa/histogram.cpp
>> @@ -139,7 +139,7 @@ double Histogram::interQuantileMean(double lowQuantile, double highQuantile) con
>>  		double freq = (cumulative_[bin + 1] - cumulative_[bin])
>>  			* (std::min(p_next, highPoint) - lowPoint);
>>  
>> -		/* Accumulate weigthed bin */
>> +		/* Accumulate weighted bin */
>>  		sumBinFreq += bin * freq;
>>  		/* Accumulate weights */
>>  		cumulFreq += freq;
>>

Patch
diff mbox series

diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp
index fb1eb2a2f0b1..4d94571f903a 100644
--- a/src/ipa/libipa/histogram.cpp
+++ b/src/ipa/libipa/histogram.cpp
@@ -139,7 +139,7 @@  double Histogram::interQuantileMean(double lowQuantile, double highQuantile) con
 		double freq = (cumulative_[bin + 1] - cumulative_[bin])
 			* (std::min(p_next, highPoint) - lowPoint);
 
-		/* Accumulate weigthed bin */
+		/* Accumulate weighted bin */
 		sumBinFreq += bin * freq;
 		/* Accumulate weights */
 		cumulFreq += freq;