[libcamera-devel,2/9] libcamera: camera_manager: Sort includes alphabetically

Message ID 20190103013110.6849-2-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel,1/9] libcamera: camera_manager: Remove put() method
Related show

Commit Message

Laurent Pinchart Jan. 3, 2019, 1:31 a.m. UTC
Alphabetically sorted includes help finding where to insert new include
statements, and avoiding duplicates.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 include/libcamera/camera_manager.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Niklas Söderlund Jan. 3, 2019, 9:17 p.m. UTC | #1
Hi Laurent,

Thanks for your work.

On 2019-01-03 03:31:03 +0200, Laurent Pinchart wrote:
> Alphabetically sorted includes help finding where to insert new include
> statements, and avoiding duplicates.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  include/libcamera/camera_manager.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h
> index 43a7811b3ea2..2768a5bd2384 100644
> --- a/include/libcamera/camera_manager.h
> +++ b/include/libcamera/camera_manager.h
> @@ -7,8 +7,8 @@
>  #ifndef __LIBCAMERA_CAMERA_MANAGER_H__
>  #define __LIBCAMERA_CAMERA_MANAGER_H__
>  
> -#include <vector>
>  #include <string>
> +#include <vector>
>  
>  namespace libcamera {
>  
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h
index 43a7811b3ea2..2768a5bd2384 100644
--- a/include/libcamera/camera_manager.h
+++ b/include/libcamera/camera_manager.h
@@ -7,8 +7,8 @@ 
 #ifndef __LIBCAMERA_CAMERA_MANAGER_H__
 #define __LIBCAMERA_CAMERA_MANAGER_H__
 
-#include <vector>
 #include <string>
+#include <vector>
 
 namespace libcamera {