[libcamera-devel,v4] test: gstreamer: Add test for gstreamer single stream
diff mbox series

Message ID 20210810111847.1880064-1-vedantparanjape160201@gmail.com
State Superseded
Headers show
Series
  • [libcamera-devel,v4] test: gstreamer: Add test for gstreamer single stream
Related show

Commit Message

Vedant Paranjape Aug. 10, 2021, 11:18 a.m. UTC 
This patch adds a test to test if single stream using
libcamera's gstreamer element works.

Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>
---
 .../gstreamer_single_stream_test.cpp          | 114 ++++++++++++++++++
 test/gstreamer/meson.build                    |  19 +++
 test/meson.build                              |   1 +
 3 files changed, 134 insertions(+)
 create mode 100644 test/gstreamer/gstreamer_single_stream_test.cpp
 create mode 100644 test/gstreamer/meson.build

Comments

Paul Elder Aug. 11, 2021, 1:41 a.m. UTC | #1 
Hi Vedant,

On Tue, Aug 10, 2021 at 04:48:47PM +0530, Vedant Paranjape wrote:
> This patch adds a test to test if single stream using
> libcamera's gstreamer element works.
> 
> Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>
> ---
>  .../gstreamer_single_stream_test.cpp          | 114 ++++++++++++++++++
>  test/gstreamer/meson.build                    |  19 +++
>  test/meson.build                              |   1 +
>  3 files changed, 134 insertions(+)
>  create mode 100644 test/gstreamer/gstreamer_single_stream_test.cpp
>  create mode 100644 test/gstreamer/meson.build
> 
> diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp
> new file mode 100644
> index 00000000..53bd6897
> --- /dev/null
> +++ b/test/gstreamer/gstreamer_single_stream_test.cpp
> @@ -0,0 +1,114 @@
> +#include <gst/gst.h>
> +#include <iostream>
> +
> +#include "test.h"
> +
> +using namespace std;
> +
> +class GstreamerSingleStreamTest : public Test
> +{
> +protected:
> +	void GstreamerPrintError(GstMessage *msg)

This should be private.

> +	{
> +		GError *err;
> +		gchar *debug_info;
> +
> +		gst_message_parse_error(msg, &err, &debug_info);
> +		g_printerr("Error received from element %s: %s\n", GST_OBJECT_NAME(msg->src), err->message);
> +		g_printerr("Debugging information: %s\n", debug_info ? debug_info : "none");

These two lines should be broken up:

+		g_printerr("Error received from element %s: %s\n",
+			   GST_OBJECT_NAME(msg->src), err->message);
+		g_printerr("Debugging information: %s\n",
+			   debug_info ? debug_info : "none");

> +		g_clear_error(&err);
> +		g_free(debug_info);
> +	}
> +
> +	int init() override
> +	{
> +		/* Initialize GStreamer */
> +		GError *err_init = nullptr;
> +		if (!gst_init_check(nullptr, nullptr, &err_init)) {
> +			g_printerr("Could not initialize GStreamer: %s\n",
> +				   err_init ? err_init->message : "unknown error");
> +			if (err_init)
> +				g_error_free(err_init);
> +
> +			return TestFail;
> +		}
> +
> +		/* Create the elements */
> +		libcamera_src_ = gst_element_factory_make("libcamerasrc", "libcamera");
> +		convert0_ = gst_element_factory_make("videoconvert", "convert0");
> +		sink0_ = gst_element_factory_make("autovideosink", "sink0");
> +
> +		/* Create the empty pipeline_ */
> +		pipeline_ = gst_pipeline_new("test-pipeline");
> +
> +		if (!pipeline_ || !convert0_ || !sink0_ || !libcamera_src_) {
> +			g_printerr("Not all elements could be created.\n");
> +			return TestFail;
> +		}
> +
> +		return TestPass;
> +	}
> +
> +	void cleanup() override
> +	{
> +		gst_message_unref(msg_);
> +		gst_object_unref(bus_);
> +		gst_element_set_state(pipeline_, GST_STATE_NULL);
> +		gst_object_unref(pipeline_);
> +	}
> +
> +	int run() override
> +	{
> +		/* Build the pipeline */
> +		gst_bin_add_many(GST_BIN(pipeline_), libcamera_src_, convert0_, sink0_, NULL);
> +		if (gst_element_link_many(libcamera_src_, convert0_, sink0_, NULL) != TRUE) {

Same here.

> +			g_printerr("Elements could not be linked.\n");
> +			gst_object_unref(pipeline_);
> +			return TestFail;
> +		}
> +
> +		/* Start playing */
> +		ret_ = gst_element_set_state(pipeline_, GST_STATE_PLAYING);
> +		if (ret_ == GST_STATE_CHANGE_FAILURE) {
> +			g_printerr("Unable to set the pipeline to the playing state.\n");
> +			gst_object_unref(pipeline_);
> +			return TestFail;
> +		}
> +
> +		/* Wait until error or EOS or timeout after 2 seconds*/
> +		GstClockTime timeout = 2000000000;
> +		bus_ = gst_element_get_bus(pipeline_);
> +		msg_ = gst_bus_timed_pop_filtered(bus_, timeout,
> +						  GstMessageType((uint)GST_MESSAGE_ERROR | (uint)GST_MESSAGE_EOS));

I know checkstyle does this, but imo it's shifted way too much over; I
think just simply one tab in is fine:

+		msg_ = gst_bus_timed_pop_filtered(bus_, timeout,
+			GstMessageType((uint)GST_MESSAGE_ERROR | (uint)GST_MESSAGE_EOS));


Other than that, looks good to me.

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> +
> +		/* Parse error message */
> +		if (msg_ == NULL)
> +			return TestPass;
> +
> +		switch (GST_MESSAGE_TYPE(msg_)) {
> +		case GST_MESSAGE_ERROR:
> +			GstreamerPrintError(msg_);
> +			return TestFail;
> +			break;
> +		case GST_MESSAGE_EOS:
> +			g_print("End-Of-Stream reached.\n");
> +			return TestFail;
> +			break;
> +		default:
> +			g_printerr("Unexpected message received.\n");
> +			return TestFail;
> +			break;
> +		}
> +
> +		return TestPass;
> +	}
> +
> +private:
> +	GstElement *pipeline_, *libcamera_src_, *convert0_, *sink0_;
> +	GstBus *bus_;
> +	GstMessage *msg_;
> +	GstStateChangeReturn ret_;
> +};
> +
> +TEST_REGISTER(GstreamerSingleStreamTest)
> +
> diff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build
> new file mode 100644
> index 00000000..b99aa0da
> --- /dev/null
> +++ b/test/gstreamer/meson.build
> @@ -0,0 +1,19 @@
> +# SPDX-License-Identifier: CC0-1.0
> +
> +if not gst_enabled
> +    subdir_done()
> +endif
> +
> +gstreamer_tests = [
> +    ['single_stream_test',   'gstreamer_single_stream_test.cpp'],
> +]
> +gstreamer_dep = dependency('gstreamer-1.0', required: true)
> +
> +foreach t : gstreamer_tests
> +    exe = executable(t[0], t[1],
> +                     dependencies : [libcamera_private, gstreamer_dep],
> +                     link_with : test_libraries,
> +                     include_directories : test_includes_internal)
> +
> +    test(t[0], exe, suite : 'gstreamer', is_parallel : false)
> +endforeach
> diff --git a/test/meson.build b/test/meson.build
> index 3bceb5df..d0466f17 100644
> --- a/test/meson.build
> +++ b/test/meson.build
> @@ -11,6 +11,7 @@ subdir('libtest')
>  
>  subdir('camera')
>  subdir('controls')
> +subdir('gstreamer')
>  subdir('ipa')
>  subdir('ipc')
>  subdir('log')
> -- 
> 2.25.1
>
Vedant Paranjape Aug. 11, 2021, 5:47 a.m. UTC | #2 
Hi Paul,
Will make the changes

Regards,
Vedant

On Wed, 11 Aug, 2021, 07:11 , <paul.elder@ideasonboard.com> wrote:

> Hi Vedant,
>
> On Tue, Aug 10, 2021 at 04:48:47PM +0530, Vedant Paranjape wrote:
> > This patch adds a test to test if single stream using
> > libcamera's gstreamer element works.
> >
> > Signed-off-by: Vedant Paranjape <vedantparanjape160201@gmail.com>
> > ---
> >  .../gstreamer_single_stream_test.cpp          | 114 ++++++++++++++++++
> >  test/gstreamer/meson.build                    |  19 +++
> >  test/meson.build                              |   1 +
> >  3 files changed, 134 insertions(+)
> >  create mode 100644 test/gstreamer/gstreamer_single_stream_test.cpp
> >  create mode 100644 test/gstreamer/meson.build
> >
> > diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp
> b/test/gstreamer/gstreamer_single_stream_test.cpp
> > new file mode 100644
> > index 00000000..53bd6897
> > --- /dev/null
> > +++ b/test/gstreamer/gstreamer_single_stream_test.cpp
> > @@ -0,0 +1,114 @@
> > +#include <gst/gst.h>
> > +#include <iostream>
> > +
> > +#include "test.h"
> > +
> > +using namespace std;
> > +
> > +class GstreamerSingleStreamTest : public Test
> > +{
> > +protected:
> > +     void GstreamerPrintError(GstMessage *msg)
>
> This should be private.
>
> > +     {
> > +             GError *err;
> > +             gchar *debug_info;
> > +
> > +             gst_message_parse_error(msg, &err, &debug_info);
> > +             g_printerr("Error received from element %s: %s\n",
> GST_OBJECT_NAME(msg->src), err->message);
> > +             g_printerr("Debugging information: %s\n", debug_info ?
> debug_info : "none");
>
> These two lines should be broken up:
>
> +               g_printerr("Error received from element %s: %s\n",
> +                          GST_OBJECT_NAME(msg->src), err->message);
> +               g_printerr("Debugging information: %s\n",
> +                          debug_info ? debug_info : "none");
>
> > +             g_clear_error(&err);
> > +             g_free(debug_info);
> > +     }
> > +
> > +     int init() override
> > +     {
> > +             /* Initialize GStreamer */
> > +             GError *err_init = nullptr;
> > +             if (!gst_init_check(nullptr, nullptr, &err_init)) {
> > +                     g_printerr("Could not initialize GStreamer: %s\n",
> > +                                err_init ? err_init->message : "unknown
> error");
> > +                     if (err_init)
> > +                             g_error_free(err_init);
> > +
> > +                     return TestFail;
> > +             }
> > +
> > +             /* Create the elements */
> > +             libcamera_src_ = gst_element_factory_make("libcamerasrc",
> "libcamera");
> > +             convert0_ = gst_element_factory_make("videoconvert",
> "convert0");
> > +             sink0_ = gst_element_factory_make("autovideosink",
> "sink0");
> > +
> > +             /* Create the empty pipeline_ */
> > +             pipeline_ = gst_pipeline_new("test-pipeline");
> > +
> > +             if (!pipeline_ || !convert0_ || !sink0_ ||
> !libcamera_src_) {
> > +                     g_printerr("Not all elements could be created.\n");
> > +                     return TestFail;
> > +             }
> > +
> > +             return TestPass;
> > +     }
> > +
> > +     void cleanup() override
> > +     {
> > +             gst_message_unref(msg_);
> > +             gst_object_unref(bus_);
> > +             gst_element_set_state(pipeline_, GST_STATE_NULL);
> > +             gst_object_unref(pipeline_);
> > +     }
> > +
> > +     int run() override
> > +     {
> > +             /* Build the pipeline */
> > +             gst_bin_add_many(GST_BIN(pipeline_), libcamera_src_,
> convert0_, sink0_, NULL);
> > +             if (gst_element_link_many(libcamera_src_, convert0_,
> sink0_, NULL) != TRUE) {
>
> Same here.
>
> > +                     g_printerr("Elements could not be linked.\n");
> > +                     gst_object_unref(pipeline_);
> > +                     return TestFail;
> > +             }
> > +
> > +             /* Start playing */
> > +             ret_ = gst_element_set_state(pipeline_, GST_STATE_PLAYING);
> > +             if (ret_ == GST_STATE_CHANGE_FAILURE) {
> > +                     g_printerr("Unable to set the pipeline to the
> playing state.\n");
> > +                     gst_object_unref(pipeline_);
> > +                     return TestFail;
> > +             }
> > +
> > +             /* Wait until error or EOS or timeout after 2 seconds*/
> > +             GstClockTime timeout = 2000000000;
> > +             bus_ = gst_element_get_bus(pipeline_);
> > +             msg_ = gst_bus_timed_pop_filtered(bus_, timeout,
> > +
>  GstMessageType((uint)GST_MESSAGE_ERROR | (uint)GST_MESSAGE_EOS));
>
> I know checkstyle does this, but imo it's shifted way too much over; I
> think just simply one tab in is fine:
>
> +               msg_ = gst_bus_timed_pop_filtered(bus_, timeout,
> +                       GstMessageType((uint)GST_MESSAGE_ERROR |
> (uint)GST_MESSAGE_EOS));
>
>
> Other than that, looks good to me.
>
> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
>
> > +
> > +             /* Parse error message */
> > +             if (msg_ == NULL)
> > +                     return TestPass;
> > +
> > +             switch (GST_MESSAGE_TYPE(msg_)) {
> > +             case GST_MESSAGE_ERROR:
> > +                     GstreamerPrintError(msg_);
> > +                     return TestFail;
> > +                     break;
> > +             case GST_MESSAGE_EOS:
> > +                     g_print("End-Of-Stream reached.\n");
> > +                     return TestFail;
> > +                     break;
> > +             default:
> > +                     g_printerr("Unexpected message received.\n");
> > +                     return TestFail;
> > +                     break;
> > +             }
> > +
> > +             return TestPass;
> > +     }
> > +
> > +private:
> > +     GstElement *pipeline_, *libcamera_src_, *convert0_, *sink0_;
> > +     GstBus *bus_;
> > +     GstMessage *msg_;
> > +     GstStateChangeReturn ret_;
> > +};
> > +
> > +TEST_REGISTER(GstreamerSingleStreamTest)
> > +
> > diff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build
> > new file mode 100644
> > index 00000000..b99aa0da
> > --- /dev/null
> > +++ b/test/gstreamer/meson.build
> > @@ -0,0 +1,19 @@
> > +# SPDX-License-Identifier: CC0-1.0
> > +
> > +if not gst_enabled
> > +    subdir_done()
> > +endif
> > +
> > +gstreamer_tests = [
> > +    ['single_stream_test',   'gstreamer_single_stream_test.cpp'],
> > +]
> > +gstreamer_dep = dependency('gstreamer-1.0', required: true)
> > +
> > +foreach t : gstreamer_tests
> > +    exe = executable(t[0], t[1],
> > +                     dependencies : [libcamera_private, gstreamer_dep],
> > +                     link_with : test_libraries,
> > +                     include_directories : test_includes_internal)
> > +
> > +    test(t[0], exe, suite : 'gstreamer', is_parallel : false)
> > +endforeach
> > diff --git a/test/meson.build b/test/meson.build
> > index 3bceb5df..d0466f17 100644
> > --- a/test/meson.build
> > +++ b/test/meson.build
> > @@ -11,6 +11,7 @@ subdir('libtest')
> >
> >  subdir('camera')
> >  subdir('controls')
> > +subdir('gstreamer')
> >  subdir('ipa')
> >  subdir('ipc')
> >  subdir('log')
> > --
> > 2.25.1
> >
>

Patch
diff mbox series 

diff --git a/test/gstreamer/gstreamer_single_stream_test.cpp b/test/gstreamer/gstreamer_single_stream_test.cpp
new file mode 100644
index 00000000..53bd6897
--- /dev/null
+++ b/test/gstreamer/gstreamer_single_stream_test.cpp
@@ -0,0 +1,114 @@ 
+#include <gst/gst.h>
+#include <iostream>
+
+#include "test.h"
+
+using namespace std;
+
+class GstreamerSingleStreamTest : public Test
+{
+protected:
+	void GstreamerPrintError(GstMessage *msg)
+	{
+		GError *err;
+		gchar *debug_info;
+
+		gst_message_parse_error(msg, &err, &debug_info);
+		g_printerr("Error received from element %s: %s\n", GST_OBJECT_NAME(msg->src), err->message);
+		g_printerr("Debugging information: %s\n", debug_info ? debug_info : "none");
+		g_clear_error(&err);
+		g_free(debug_info);
+	}
+
+	int init() override
+	{
+		/* Initialize GStreamer */
+		GError *err_init = nullptr;
+		if (!gst_init_check(nullptr, nullptr, &err_init)) {
+			g_printerr("Could not initialize GStreamer: %s\n",
+				   err_init ? err_init->message : "unknown error");
+			if (err_init)
+				g_error_free(err_init);
+
+			return TestFail;
+		}
+
+		/* Create the elements */
+		libcamera_src_ = gst_element_factory_make("libcamerasrc", "libcamera");
+		convert0_ = gst_element_factory_make("videoconvert", "convert0");
+		sink0_ = gst_element_factory_make("autovideosink", "sink0");
+
+		/* Create the empty pipeline_ */
+		pipeline_ = gst_pipeline_new("test-pipeline");
+
+		if (!pipeline_ || !convert0_ || !sink0_ || !libcamera_src_) {
+			g_printerr("Not all elements could be created.\n");
+			return TestFail;
+		}
+
+		return TestPass;
+	}
+
+	void cleanup() override
+	{
+		gst_message_unref(msg_);
+		gst_object_unref(bus_);
+		gst_element_set_state(pipeline_, GST_STATE_NULL);
+		gst_object_unref(pipeline_);
+	}
+
+	int run() override
+	{
+		/* Build the pipeline */
+		gst_bin_add_many(GST_BIN(pipeline_), libcamera_src_, convert0_, sink0_, NULL);
+		if (gst_element_link_many(libcamera_src_, convert0_, sink0_, NULL) != TRUE) {
+			g_printerr("Elements could not be linked.\n");
+			gst_object_unref(pipeline_);
+			return TestFail;
+		}
+
+		/* Start playing */
+		ret_ = gst_element_set_state(pipeline_, GST_STATE_PLAYING);
+		if (ret_ == GST_STATE_CHANGE_FAILURE) {
+			g_printerr("Unable to set the pipeline to the playing state.\n");
+			gst_object_unref(pipeline_);
+			return TestFail;
+		}
+
+		/* Wait until error or EOS or timeout after 2 seconds*/
+		GstClockTime timeout = 2000000000;
+		bus_ = gst_element_get_bus(pipeline_);
+		msg_ = gst_bus_timed_pop_filtered(bus_, timeout,
+						  GstMessageType((uint)GST_MESSAGE_ERROR | (uint)GST_MESSAGE_EOS));
+
+		/* Parse error message */
+		if (msg_ == NULL)
+			return TestPass;
+
+		switch (GST_MESSAGE_TYPE(msg_)) {
+		case GST_MESSAGE_ERROR:
+			GstreamerPrintError(msg_);
+			return TestFail;
+			break;
+		case GST_MESSAGE_EOS:
+			g_print("End-Of-Stream reached.\n");
+			return TestFail;
+			break;
+		default:
+			g_printerr("Unexpected message received.\n");
+			return TestFail;
+			break;
+		}
+
+		return TestPass;
+	}
+
+private:
+	GstElement *pipeline_, *libcamera_src_, *convert0_, *sink0_;
+	GstBus *bus_;
+	GstMessage *msg_;
+	GstStateChangeReturn ret_;
+};
+
+TEST_REGISTER(GstreamerSingleStreamTest)
+
diff --git a/test/gstreamer/meson.build b/test/gstreamer/meson.build
new file mode 100644
index 00000000..b99aa0da
--- /dev/null
+++ b/test/gstreamer/meson.build
@@ -0,0 +1,19 @@ 
+# SPDX-License-Identifier: CC0-1.0
+
+if not gst_enabled
+    subdir_done()
+endif
+
+gstreamer_tests = [
+    ['single_stream_test',   'gstreamer_single_stream_test.cpp'],
+]
+gstreamer_dep = dependency('gstreamer-1.0', required: true)
+
+foreach t : gstreamer_tests
+    exe = executable(t[0], t[1],
+                     dependencies : [libcamera_private, gstreamer_dep],
+                     link_with : test_libraries,
+                     include_directories : test_includes_internal)
+
+    test(t[0], exe, suite : 'gstreamer', is_parallel : false)
+endforeach
diff --git a/test/meson.build b/test/meson.build
index 3bceb5df..d0466f17 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -11,6 +11,7 @@  subdir('libtest')
 
 subdir('camera')
 subdir('controls')
+subdir('gstreamer')
 subdir('ipa')
 subdir('ipc')
 subdir('log')