| Message ID | 20210702130707.25345-1-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | d7415bc4e46fe8aa25a495c79516d9882a35a5aa |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thank you for your patch. On Fri, 2 Jul 2021 at 14:07, Laurent Pinchart < laurent.pinchart@ideasonboard.com> wrote: > The [[maybe_unused]] in the IMX477 camera helper isn't needed. This had > been pointed out by Naush during review, but I failed to update the code > before pushing. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Naushir Patuck <naush@raspberrypi.com> I was just preparing a patch with the very same change as part of the imx477 long exposure series :-) > --- > src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp > b/src/ipa/raspberrypi/cam_helper_imx477.cpp > index 4098fde6f322..efd1a5893db8 100644 > --- a/src/ipa/raspberrypi/cam_helper_imx477.cpp > +++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp > @@ -23,7 +23,7 @@ constexpr uint32_t expHiReg = 0x0202; > constexpr uint32_t expLoReg = 0x0203; > constexpr uint32_t gainHiReg = 0x0204; > constexpr uint32_t gainLoReg = 0x0205; > -constexpr std::initializer_list<uint32_t> registerList [[maybe_unused]] = > { expHiReg, expLoReg, gainHiReg, gainLoReg }; > +constexpr std::initializer_list<uint32_t> registerList = { expHiReg, > expLoReg, gainHiReg, gainLoReg }; > > class CamHelperImx477 : public CamHelper > { > -- > Regards, > > Laurent Pinchart > >
diff --git a/src/ipa/raspberrypi/cam_helper_imx477.cpp b/src/ipa/raspberrypi/cam_helper_imx477.cpp index 4098fde6f322..efd1a5893db8 100644 --- a/src/ipa/raspberrypi/cam_helper_imx477.cpp +++ b/src/ipa/raspberrypi/cam_helper_imx477.cpp @@ -23,7 +23,7 @@ constexpr uint32_t expHiReg = 0x0202; constexpr uint32_t expLoReg = 0x0203; constexpr uint32_t gainHiReg = 0x0204; constexpr uint32_t gainLoReg = 0x0205; -constexpr std::initializer_list<uint32_t> registerList [[maybe_unused]] = { expHiReg, expLoReg, gainHiReg, gainLoReg }; +constexpr std::initializer_list<uint32_t> registerList = { expHiReg, expLoReg, gainHiReg, gainLoReg }; class CamHelperImx477 : public CamHelper {
The [[maybe_unused]] in the IMX477 camera helper isn't needed. This had been pointed out by Naush during review, but I failed to update the code before pushing. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)