[libcamera-devel,v2,4/4] ipa: raspberrypi: Make variable names consistent
diff mbox series

Message ID 20210701113442.111718-5-naush@raspberrypi.com
State Superseded
Headers show
Series
  • Raspberry Pi: Enable imx477 long exposure modes
Related show

Commit Message

Naushir Patuck July 1, 2021, 11:34 a.m. UTC
s/DefaultAnalogueGain/defaultAnalogueGain/
s/DefaultExposureTime/defaultExposureTime/

Change these for consistency with the other static const variables.

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
---
 src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Laurent Pinchart July 1, 2021, 11:57 p.m. UTC | #1
Hi Naush,

Thank you for the patch.

On Thu, Jul 01, 2021 at 12:34:42PM +0100, Naushir Patuck wrote:
> s/DefaultAnalogueGain/defaultAnalogueGain/
> s/DefaultExposureTime/defaultExposureTime/
> 
> Change these for consistency with the other static const variables.
> 
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
> Reviewed-by: David Plowman <david.plowman@raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> index dd20c854c788..e9bd724f5eac 100644
> --- a/src/ipa/raspberrypi/raspberrypi.cpp
> +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> @@ -59,8 +59,8 @@ using namespace std::literals::chrono_literals;
>  using utils::Duration;
>  
>  /* Configure the sensor with these values initially. */
> -constexpr double DefaultAnalogueGain = 1.0;
> -constexpr Duration DefaultExposureTime = 20.0ms;
> +constexpr double defaultAnalogueGain = 1.0;
> +constexpr Duration defaultExposureTime = 20.0ms;
>  constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;
>  constexpr Duration defaultMaxFrameDuration = 250.0s;
>  
> @@ -390,8 +390,8 @@ int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,
>  		/* Supply initial values for gain and exposure. */
>  		ControlList ctrls(sensorCtrls_);
>  		AgcStatus agcStatus;
> -		agcStatus.shutter_time = DefaultExposureTime;
> -		agcStatus.analogue_gain = DefaultAnalogueGain;
> +		agcStatus.shutter_time = defaultExposureTime;
> +		agcStatus.analogue_gain = defaultAnalogueGain;
>  		applyAGC(&agcStatus, ctrls);
>  
>  		ASSERT(controls);

Patch
diff mbox series

diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
index dd20c854c788..e9bd724f5eac 100644
--- a/src/ipa/raspberrypi/raspberrypi.cpp
+++ b/src/ipa/raspberrypi/raspberrypi.cpp
@@ -59,8 +59,8 @@  using namespace std::literals::chrono_literals;
 using utils::Duration;
 
 /* Configure the sensor with these values initially. */
-constexpr double DefaultAnalogueGain = 1.0;
-constexpr Duration DefaultExposureTime = 20.0ms;
+constexpr double defaultAnalogueGain = 1.0;
+constexpr Duration defaultExposureTime = 20.0ms;
 constexpr Duration defaultMinFrameDuration = 1.0s / 30.0;
 constexpr Duration defaultMaxFrameDuration = 250.0s;
 
@@ -390,8 +390,8 @@  int IPARPi::configure(const IPACameraSensorInfo &sensorInfo,
 		/* Supply initial values for gain and exposure. */
 		ControlList ctrls(sensorCtrls_);
 		AgcStatus agcStatus;
-		agcStatus.shutter_time = DefaultExposureTime;
-		agcStatus.analogue_gain = DefaultAnalogueGain;
+		agcStatus.shutter_time = defaultExposureTime;
+		agcStatus.analogue_gain = defaultAnalogueGain;
 		applyAGC(&agcStatus, ctrls);
 
 		ASSERT(controls);