[libcamera-devel,0/2] android: Introduce CameraCapabilities

12669 mbox series

Hi,
   previously sent as RFC, I've taken in Laurent's comment about adding
one include in camera_capabilities.h and added one patch before the 'real' one
to resort source files alphabetically.

Added also Paul's tags, thanks.


Jacopo Mondi (2):
  android: Sort source files alphabetically
  android: Introduce CameraCapabilties class

 src/android/camera_capabilities.cpp | 1164 +++++++++++++++++++++++++++
 src/android/camera_capabilities.h   |   65 ++
 src/android/camera_device.cpp       | 1147 +-------------------------
 src/android/camera_device.h         |   27 +-
 src/android/meson.build             |    3 +-
 5 files changed, 1246 insertions(+), 1160 deletions(-)
 create mode 100644 src/android/camera_capabilities.cpp
 create mode 100644 src/android/camera_capabilities.h

--
2.31.1

Hi Jacopo, thank you for the patch.

On Tue, Jun 22, 2021 at 12:29 AM Jacopo Mondi <jacopo@jmondi.org> wrote:

> Sort the list of the Android HAL source file alphabetically.
>
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
>

I expect this is detected by the style check script, isn't it?

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

> ---
>  src/android/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/android/meson.build b/src/android/meson.build
> index 3893e5b5b832..f27fd5316705 100644
> --- a/src/android/meson.build
> +++ b/src/android/meson.build
> @@ -44,9 +44,9 @@ subdir('cros')
>
>  android_hal_sources = files([
>      'camera3_hal.cpp',
> -    'camera_hal_manager.cpp',
>      'camera_device.cpp',
>      'camera_hal_config.cpp',
> +    'camera_hal_manager.cpp',
>      'camera_metadata.cpp',
>      'camera_ops.cpp',
>      'camera_stream.cpp',
> --
> 2.31.1
>
>

Hi Jacopo,

On Mon, Jun 21, 2021 at 05:29:53PM +0200, Jacopo Mondi wrote:
> Sort the list of the Android HAL source file alphabetically.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
>  src/android/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/meson.build b/src/android/meson.build
> index 3893e5b5b832..f27fd5316705 100644
> --- a/src/android/meson.build
> +++ b/src/android/meson.build
> @@ -44,9 +44,9 @@ subdir('cros')
>  
>  android_hal_sources = files([
>      'camera3_hal.cpp',
> -    'camera_hal_manager.cpp',
>      'camera_device.cpp',
>      'camera_hal_config.cpp',
> +    'camera_hal_manager.cpp',
>      'camera_metadata.cpp',
>      'camera_ops.cpp',
>      'camera_stream.cpp',
> -- 
> 2.31.1
>

On Tue, Jun 22, 2021 at 09:29:23AM +0900, Hirokazu Honda wrote:
> On Tue, Jun 22, 2021 at 12:29 AM Jacopo Mondi <jacopo@jmondi.org> wrote:
> 
> > Sort the list of the Android HAL source file alphabetically.
> >
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> 
> I expect this is detected by the style check script, isn't it?

This would be nice, but checkstyle.py doesn't have support for this yet,
and it's a rabbit hole I'm not keen on exploring at this moment :-)

> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > ---
> >  src/android/meson.build | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/android/meson.build b/src/android/meson.build
> > index 3893e5b5b832..f27fd5316705 100644
> > --- a/src/android/meson.build
> > +++ b/src/android/meson.build
> > @@ -44,9 +44,9 @@ subdir('cros')
> >
> >  android_hal_sources = files([
> >      'camera3_hal.cpp',
> > -    'camera_hal_manager.cpp',
> >      'camera_device.cpp',
> >      'camera_hal_config.cpp',
> > +    'camera_hal_manager.cpp',
> >      'camera_metadata.cpp',
> >      'camera_ops.cpp',
> >      'camera_stream.cpp',