[libcamera-devel,0/6] Raspberry Pi: Metadata parsing improvements

12580 mbox series

Hi,

This series of patches provide some improvements to our SMIA metadata parser
that were long on my todo list.

Patches 1/6 to 4/6 are mostly formatting and syntactic changes to get us more
in-line with libcamera formatting guidelines.

Patch 5/6 inlines the SMIA parser in all CamHelpers that use time instead of
dynamically allocating the object.

Patch 6/6 makes the SMIA metadata parser code more generic so that it can
be directly used by the imx477 and imx219 CamHelpers instead of being subclassed.

Thanks,
Naush

Naushir Patuck (6):
  ipa: raspberrypi: Non-functional formatting fixes to md_parser.hpp
  ipa: raspberrypi: Set default values for member variables of MdParser
  ipa: raspberrypi: Rename md_parser.cpp to md_parser_smia.cpp
  ipa: raspberrypi: Non-functional formatting fixes to
    md_parser_smia.cpp
  ipa: raspberrypi: Embed the metadata parser in the sensor CamHelper
    classes
  ipa: raspberrypi: Generalise the SMIA metadata parser

 src/ipa/raspberrypi/cam_helper.cpp        |   5 +-
 src/ipa/raspberrypi/cam_helper.hpp        |   2 +-
 src/ipa/raspberrypi/cam_helper_imx219.cpp | 123 +++------------
 src/ipa/raspberrypi/cam_helper_imx290.cpp |   2 +-
 src/ipa/raspberrypi/cam_helper_imx477.cpp | 127 +++------------
 src/ipa/raspberrypi/cam_helper_ov5647.cpp |   2 +-
 src/ipa/raspberrypi/md_parser.cpp         | 102 -------------
 src/ipa/raspberrypi/md_parser.hpp         | 178 ++++++++++++++--------
 src/ipa/raspberrypi/md_parser_smia.cpp    | 171 +++++++++++++++++++++
 src/ipa/raspberrypi/meson.build           |   2 +-
 10 files changed, 340 insertions(+), 374 deletions(-)
 delete mode 100644 src/ipa/raspberrypi/md_parser.cpp
 create mode 100644 src/ipa/raspberrypi/md_parser_smia.cpp

Hi Naush

Yep, not much to complain about here!!

On Mon, 14 Jun 2021 at 10:53, Naushir Patuck <naush@raspberrypi.com> wrote:
>
> The file implements the MdParserSmia class, so change the file name to reflect
> this.
>
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>

Reviewed-by: David Plowman <david.plowman@raspberrypi.com>

Thanks
David

> ---
>  src/ipa/raspberrypi/{md_parser.cpp => md_parser_smia.cpp} | 0
>  src/ipa/raspberrypi/meson.build                           | 2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename src/ipa/raspberrypi/{md_parser.cpp => md_parser_smia.cpp} (100%)
>
> diff --git a/src/ipa/raspberrypi/md_parser.cpp b/src/ipa/raspberrypi/md_parser_smia.cpp
> similarity index 100%
> rename from src/ipa/raspberrypi/md_parser.cpp
> rename to src/ipa/raspberrypi/md_parser_smia.cpp
> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build
> index d1397a3211f0..230356d3ce3a 100644
> --- a/src/ipa/raspberrypi/meson.build
> +++ b/src/ipa/raspberrypi/meson.build
> @@ -16,7 +16,7 @@ rpi_ipa_includes = [
>
>  rpi_ipa_sources = files([
>      'raspberrypi.cpp',
> -    'md_parser.cpp',
> +    'md_parser_smia.cpp',
>      'cam_helper.cpp',
>      'cam_helper_ov5647.cpp',
>      'cam_helper_imx219.cpp',
> --
> 2.25.1
>

Hi Naush,

Thank you for the patch.

On Mon, Jun 14, 2021 at 10:53:37AM +0100, Naushir Patuck wrote:
> The file implements the MdParserSmia class, so change the file name to reflect
> this.
> 
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/ipa/raspberrypi/{md_parser.cpp => md_parser_smia.cpp} | 0
>  src/ipa/raspberrypi/meson.build                           | 2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename src/ipa/raspberrypi/{md_parser.cpp => md_parser_smia.cpp} (100%)
> 
> diff --git a/src/ipa/raspberrypi/md_parser.cpp b/src/ipa/raspberrypi/md_parser_smia.cpp
> similarity index 100%
> rename from src/ipa/raspberrypi/md_parser.cpp
> rename to src/ipa/raspberrypi/md_parser_smia.cpp
> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build
> index d1397a3211f0..230356d3ce3a 100644
> --- a/src/ipa/raspberrypi/meson.build
> +++ b/src/ipa/raspberrypi/meson.build
> @@ -16,7 +16,7 @@ rpi_ipa_includes = [
>  
>  rpi_ipa_sources = files([
>      'raspberrypi.cpp',
> -    'md_parser.cpp',
> +    'md_parser_smia.cpp',
>      'cam_helper.cpp',
>      'cam_helper_ov5647.cpp',
>      'cam_helper_imx219.cpp',