[libcamera-devel] pipeline: raspberrypi: Fix typo in a comment
diff mbox series

Message ID 20210415101741.1215178-1-naush@raspberrypi.com
State Accepted
Headers show
Series
  • [libcamera-devel] pipeline: raspberrypi: Fix typo in a comment
Related show

Commit Message

Naushir Patuck April 15, 2021, 10:17 a.m. UTC 
s/embedded/bayer/

Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
---
 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sebastian Fricke April 15, 2021, 10:48 a.m. UTC | #1 
Hey Naushir,

Thank you for the patch.

On 15.04.2021 11:17, Naushir Patuck wrote:
>s/embedded/bayer/
>
>Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: Sebastian Fricke <sebastian.fricke@posteo.net>

>---
> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
>index f22e286ed87a..2a917455500f 100644
>--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
>+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
>@@ -1802,7 +1802,7 @@ bool RPiCameraData::findMatchingBuffers(BayerFrame &bayerFrame, FrameBuffer *&em
> 			 * pending embedded data buffers.
> 			 */
> 			if (bayerRequeueCount == unicam_[Unicam::Image].getBuffers().size()) {
>-				/* The embedded queue must be empty at this point! */
>+				/* The bayer queue must be empty at this point! */
> 				ASSERT(bayerQueue_.empty());
>
> 				LOG(RPI, Warning) << "Flushing embedded data stream!";
>-- 
>2.25.1
>
>_______________________________________________
>libcamera-devel mailing list
>libcamera-devel@lists.libcamera.org
>https://lists.libcamera.org/listinfo/libcamera-devel
Laurent Pinchart April 20, 2021, 12:36 a.m. UTC | #2 
Hi Naush,

Thank you for the patch.

On Thu, Apr 15, 2021 at 11:17:42AM +0100, Naushir Patuck wrote:
> s/embedded/bayer/
> 
> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> index f22e286ed87a..2a917455500f 100644
> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
> @@ -1802,7 +1802,7 @@ bool RPiCameraData::findMatchingBuffers(BayerFrame &bayerFrame, FrameBuffer *&em
>  			 * pending embedded data buffers.
>  			 */
>  			if (bayerRequeueCount == unicam_[Unicam::Image].getBuffers().size()) {
> -				/* The embedded queue must be empty at this point! */
> +				/* The bayer queue must be empty at this point! */
>  				ASSERT(bayerQueue_.empty());
>  
>  				LOG(RPI, Warning) << "Flushing embedded data stream!";

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
index f22e286ed87a..2a917455500f 100644
--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
@@ -1802,7 +1802,7 @@  bool RPiCameraData::findMatchingBuffers(BayerFrame &bayerFrame, FrameBuffer *&em
 			 * pending embedded data buffers.
 			 */
 			if (bayerRequeueCount == unicam_[Unicam::Image].getBuffers().size()) {
-				/* The embedded queue must be empty at this point! */
+				/* The bayer queue must be empty at this point! */
 				ASSERT(bayerQueue_.empty());
 
 				LOG(RPI, Warning) << "Flushing embedded data stream!";