[libcamera-devel,v4,09/11] android: jpeg: Use CameraBuffer::jpegBufferSize()
diff mbox series

Message ID 20210302141844.126634-10-jacopo@jmondi.org
State Accepted
Headers show
Series
  • android: Supports memory backends
Related show

Commit Message

Jacopo Mondi March 2, 2021, 2:18 p.m. UTC 
Use the newly introduced function to retrieve the size of
the JPEG encoding destination buffer, in order to calculate where
the JPEG_BLOB_ID should be placed.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/android/jpeg/post_processor_jpeg.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart March 2, 2021, 3:07 p.m. UTC | #1 
Hi Jacopo,

Thank you for the patch.

On Tue, Mar 02, 2021 at 03:18:42PM +0100, Jacopo Mondi wrote:
> Use the newly introduced function to retrieve the size of
> the JPEG encoding destination buffer, in order to calculate where
> the JPEG_BLOB_ID should be placed.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/android/jpeg/post_processor_jpeg.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp
> index 83244ce6769e..3bf16996a147 100644
> --- a/src/android/jpeg/post_processor_jpeg.cpp
> +++ b/src/android/jpeg/post_processor_jpeg.cpp
> @@ -183,7 +183,7 @@ int PostProcessorJpeg::process(const FrameBuffer &source,
>  
>  	/* Fill in the JPEG blob header. */
>  	uint8_t *resultPtr = destination->plane(0).data()
> -			   + destination->plane(0).size()
> +			   + destination->jpegBufferSize(cameraDevice_->maxJpegBufferSize())
>  			   - sizeof(struct camera3_jpeg_blob);
>  	auto *blob = reinterpret_cast<struct camera3_jpeg_blob *>(resultPtr);
>  	blob->jpeg_blob_id = CAMERA3_JPEG_BLOB_ID;

Patch
diff mbox series 

diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp
index 83244ce6769e..3bf16996a147 100644
--- a/src/android/jpeg/post_processor_jpeg.cpp
+++ b/src/android/jpeg/post_processor_jpeg.cpp
@@ -183,7 +183,7 @@  int PostProcessorJpeg::process(const FrameBuffer &source,
 
 	/* Fill in the JPEG blob header. */
 	uint8_t *resultPtr = destination->plane(0).data()
-			   + destination->plane(0).size()
+			   + destination->jpegBufferSize(cameraDevice_->maxJpegBufferSize())
 			   - sizeof(struct camera3_jpeg_blob);
 	auto *blob = reinterpret_cast<struct camera3_jpeg_blob *>(resultPtr);
 	blob->jpeg_blob_id = CAMERA3_JPEG_BLOB_ID;