[libcamera-devel,v2,1/9] libcamera: properties: SensorPhysicalSize draft property
diff mbox series

Message ID 20201218164754.81422-2-jacopo@jmondi.org
State Superseded
Delegated to: Jacopo Mondi
Headers show
Series
  • libcamera: Introduce sensor database
Related show

Commit Message

Jacopo Mondi Dec. 18, 2020, 4:47 p.m. UTC 
Define the 'SensorPhysicalSize' draft property. The property is
currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/property_ids.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Laurent Pinchart Dec. 20, 2020, 6:02 a.m. UTC | #1 
Hi Jacopo,

Thank you for the patch.

On Fri, Dec 18, 2020 at 05:47:46PM +0100, Jacopo Mondi wrote:
> Define the 'SensorPhysicalSize' draft property. The property is
> currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  src/libcamera/property_ids.yaml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> index 64e88f0361d6..f8e32c1bd8cf 100644
> --- a/src/libcamera/property_ids.yaml
> +++ b/src/libcamera/property_ids.yaml
> @@ -678,4 +678,15 @@ controls:
>          \todo Turn this property into a "maximum control value" for the
>          ScalerCrop control once "dynamic" controls have been implemented.
>  
> +  # ----------------------------------------------------------------------------
> +  # Draft properties section
> +
> +  - SensorPhysicalSize:
> +      type: float
> +      size: [2]
> +      draft: true
> +      description: |
> +        The physical dimensions of the full pixel array in millimeters.
> +        Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.

We already have UnitCellSize and PixelArraySize, can't they be used to
compute this property ?

> +
>  ...
Jacopo Mondi Dec. 21, 2020, 3:06 p.m. UTC | #2 
Hi Laurent,

On Sun, Dec 20, 2020 at 08:02:29AM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Fri, Dec 18, 2020 at 05:47:46PM +0100, Jacopo Mondi wrote:
> > Define the 'SensorPhysicalSize' draft property. The property is
> > currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
> >
> > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > ---
> >  src/libcamera/property_ids.yaml | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> > index 64e88f0361d6..f8e32c1bd8cf 100644
> > --- a/src/libcamera/property_ids.yaml
> > +++ b/src/libcamera/property_ids.yaml
> > @@ -678,4 +678,15 @@ controls:
> >          \todo Turn this property into a "maximum control value" for the
> >          ScalerCrop control once "dynamic" controls have been implemented.
> >
> > +  # ----------------------------------------------------------------------------
> > +  # Draft properties section
> > +
> > +  - SensorPhysicalSize:
> > +      type: float
> > +      size: [2]
> > +      draft: true
> > +      description: |
> > +        The physical dimensions of the full pixel array in millimeters.
> > +        Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
>
> We already have UnitCellSize and PixelArraySize, can't they be used to
> compute this property ?

We could.

I would like to have these cros-verified with the current values
reported by the chromeos HALs. I still haven't been able to have a
nice list of all properties they register.

>
> > +
> >  ...
>
> --
> Regards,
>
> Laurent Pinchart
Laurent Pinchart Dec. 21, 2020, 3:16 p.m. UTC | #3 
Hi Jacopo,

On Mon, Dec 21, 2020 at 04:06:24PM +0100, Jacopo Mondi wrote:
> On Sun, Dec 20, 2020 at 08:02:29AM +0200, Laurent Pinchart wrote:
> > On Fri, Dec 18, 2020 at 05:47:46PM +0100, Jacopo Mondi wrote:
> > > Define the 'SensorPhysicalSize' draft property. The property is
> > > currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
> > >
> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > > ---
> > >  src/libcamera/property_ids.yaml | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >
> > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> > > index 64e88f0361d6..f8e32c1bd8cf 100644
> > > --- a/src/libcamera/property_ids.yaml
> > > +++ b/src/libcamera/property_ids.yaml
> > > @@ -678,4 +678,15 @@ controls:
> > >          \todo Turn this property into a "maximum control value" for the
> > >          ScalerCrop control once "dynamic" controls have been implemented.
> > >
> > > +  # ----------------------------------------------------------------------------
> > > +  # Draft properties section
> > > +
> > > +  - SensorPhysicalSize:
> > > +      type: float
> > > +      size: [2]
> > > +      draft: true
> > > +      description: |
> > > +        The physical dimensions of the full pixel array in millimeters.
> > > +        Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
> >
> > We already have UnitCellSize and PixelArraySize, can't they be used to
> > compute this property ?
> 
> We could.
> 
> I would like to have these cros-verified with the current values
> reported by the chromeos HALs. I still haven't been able to have a
> nice list of all properties they register.

That's a good idea. Is there any off-the-shelf tool we can use for that
?

> > > +
> > >  ...
Jacopo Mondi Dec. 21, 2020, 4:11 p.m. UTC | #4 
Hi Laurent,

On Mon, Dec 21, 2020 at 05:16:21PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Mon, Dec 21, 2020 at 04:06:24PM +0100, Jacopo Mondi wrote:
> > On Sun, Dec 20, 2020 at 08:02:29AM +0200, Laurent Pinchart wrote:
> > > On Fri, Dec 18, 2020 at 05:47:46PM +0100, Jacopo Mondi wrote:
> > > > Define the 'SensorPhysicalSize' draft property. The property is
> > > > currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
> > > >
> > > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > > > ---
> > > >  src/libcamera/property_ids.yaml | 11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > >
> > > > diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
> > > > index 64e88f0361d6..f8e32c1bd8cf 100644
> > > > --- a/src/libcamera/property_ids.yaml
> > > > +++ b/src/libcamera/property_ids.yaml
> > > > @@ -678,4 +678,15 @@ controls:
> > > >          \todo Turn this property into a "maximum control value" for the
> > > >          ScalerCrop control once "dynamic" controls have been implemented.
> > > >
> > > > +  # ----------------------------------------------------------------------------
> > > > +  # Draft properties section
> > > > +
> > > > +  - SensorPhysicalSize:
> > > > +      type: float
> > > > +      size: [2]
> > > > +      draft: true
> > > > +      description: |
> > > > +        The physical dimensions of the full pixel array in millimeters.
> > > > +        Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
> > >
> > > We already have UnitCellSize and PixelArraySize, can't they be used to
> > > compute this property ?
> >
> > We could.
> >
> > I would like to have these cros-verified with the current values
> > reported by the chromeos HALs. I still haven't been able to have a
> > nice list of all properties they register.
>
> That's a good idea. Is there any off-the-shelf tool we can use for that
> ?

Not that I know of, but I've nerve actually never researched if
there's any android app that can help with that.

>
> > > > +
> > > >  ...
>
> --
> Regards,
>
> Laurent Pinchart

Patch
diff mbox series 

diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml
index 64e88f0361d6..f8e32c1bd8cf 100644
--- a/src/libcamera/property_ids.yaml
+++ b/src/libcamera/property_ids.yaml
@@ -678,4 +678,15 @@  controls:
         \todo Turn this property into a "maximum control value" for the
         ScalerCrop control once "dynamic" controls have been implemented.
 
+  # ----------------------------------------------------------------------------
+  # Draft properties section
+
+  - SensorPhysicalSize:
+      type: float
+      size: [2]
+      draft: true
+      description: |
+        The physical dimensions of the full pixel array in millimeters.
+        Currently identical to ANDROID_SENSOR_INFO_PHYSICAL_SIZE.
+
 ...