| Message ID | 20201127140403.1104761-1-naush@raspberrypi.com |
|---|---|
| State | Accepted |
| Commit | 743329b642d17b314421a8119a17300db3d796b2 |
| Headers | show |
| Series |
|
| Related | show |
Hi Naush, Thanks for your work. On 2020-11-27 14:04:03 +0000, Naushir Patuck wrote: > The description text lists "stillraw" as a stream role option. This is > incorrect, it should be listed as "raw" instead. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Nice catch, Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/cam/stream_options.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp > index 27cc3912..c58272c2 100644 > --- a/src/cam/stream_options.cpp > +++ b/src/cam/stream_options.cpp > @@ -13,7 +13,7 @@ using namespace libcamera; > StreamKeyValueParser::StreamKeyValueParser() > { > addOption("role", OptionString, > - "Role for the stream (viewfinder, video, still, stillraw)", > + "Role for the stream (viewfinder, video, still, raw)", > ArgumentRequired); > addOption("width", OptionInteger, "Width in pixels", > ArgumentRequired); > -- > 2.25.1 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Naush, On Fri, Nov 27, 2020 at 02:04:03PM +0000, Naushir Patuck wrote: > The description text lists "stillraw" as a stream role option. This is > incorrect, it should be listed as "raw" instead. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > src/cam/stream_options.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp > index 27cc3912..c58272c2 100644 > --- a/src/cam/stream_options.cpp > +++ b/src/cam/stream_options.cpp > @@ -13,7 +13,7 @@ using namespace libcamera; > StreamKeyValueParser::StreamKeyValueParser() > { > addOption("role", OptionString, > - "Role for the stream (viewfinder, video, still, stillraw)", > + "Role for the stream (viewfinder, video, still, raw)", > ArgumentRequired); > addOption("width", OptionInteger, "Width in pixels", > ArgumentRequired); > -- > 2.25.1 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Naush, On 27/11/2020 14:04, Naushir Patuck wrote: > The description text lists "stillraw" as a stream role option. This is > incorrect, it should be listed as "raw" instead. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> and pushed to master with Jacopo and Niklas' tags. Thanks. Kieran > --- > src/cam/stream_options.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp > index 27cc3912..c58272c2 100644 > --- a/src/cam/stream_options.cpp > +++ b/src/cam/stream_options.cpp > @@ -13,7 +13,7 @@ using namespace libcamera; > StreamKeyValueParser::StreamKeyValueParser() > { > addOption("role", OptionString, > - "Role for the stream (viewfinder, video, still, stillraw)", > + "Role for the stream (viewfinder, video, still, raw)", > ArgumentRequired); > addOption("width", OptionInteger, "Width in pixels", > ArgumentRequired); >
diff --git a/src/cam/stream_options.cpp b/src/cam/stream_options.cpp index 27cc3912..c58272c2 100644 --- a/src/cam/stream_options.cpp +++ b/src/cam/stream_options.cpp @@ -13,7 +13,7 @@ using namespace libcamera; StreamKeyValueParser::StreamKeyValueParser() { addOption("role", OptionString, - "Role for the stream (viewfinder, video, still, stillraw)", + "Role for the stream (viewfinder, video, still, raw)", ArgumentRequired); addOption("width", OptionInteger, "Width in pixels", ArgumentRequired);
The description text lists "stillraw" as a stream role option. This is incorrect, it should be listed as "raw" instead. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/cam/stream_options.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)