| Message ID | 20201106103707.49660-3-paul.elder@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thanks for your work. On 2020-11-06 19:36:32 +0900, Paul Elder wrote: > Specify in the readme and meson file that we depend on python3-ply and > python3-jinja2 for generating the IPA interface. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > > --- > Changes in v4: > - consolidate python3-ply requirement into libcamera core deps in > README.rst > - add ply to py_modules > - add jinja2 to the readme and py_modules > - moved earlier, to right after importing mojo > > New in v3 > --- > README.rst | 2 +- > utils/ipc/meson.build | 3 +++ > utils/meson.build | 1 + > 3 files changed, 5 insertions(+), 1 deletion(-) > create mode 100644 utils/ipc/meson.build > > diff --git a/README.rst b/README.rst > index f8519b44..5c4b6989 100644 > --- a/README.rst > +++ b/README.rst > @@ -58,7 +58,7 @@ Meson Build system: [required] > pip3 install --user --upgrade meson > > for the libcamera core: [required] > - python3-yaml > + python3-yaml python3-ply python3-jinja2 > > for IPA module signing: [required] > libgnutls28-dev openssl > diff --git a/utils/ipc/meson.build b/utils/ipc/meson.build > new file mode 100644 > index 00000000..59f097f0 > --- /dev/null > +++ b/utils/ipc/meson.build > @@ -0,0 +1,3 @@ > +# SPDX-License-Identifier: CC0-1.0 > + > +py_modules += ['jinja2', 'ply'] > diff --git a/utils/meson.build b/utils/meson.build > index 7f2b9b4d..8e28ada7 100644 > --- a/utils/meson.build > +++ b/utils/meson.build > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: CC0-1.0 > > +subdir('ipc') > subdir('ipu3') > subdir('tracepoints') > > -- > 2.27.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Paul, On 06/11/2020 10:36, Paul Elder wrote: > Specify in the readme and meson file that we depend on python3-ply and > python3-jinja2 for generating the IPA interface. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Looks good to me. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > --- > Changes in v4: > - consolidate python3-ply requirement into libcamera core deps in > README.rst > - add ply to py_modules > - add jinja2 to the readme and py_modules > - moved earlier, to right after importing mojo > > New in v3 > --- > README.rst | 2 +- > utils/ipc/meson.build | 3 +++ > utils/meson.build | 1 + > 3 files changed, 5 insertions(+), 1 deletion(-) > create mode 100644 utils/ipc/meson.build > > diff --git a/README.rst b/README.rst > index f8519b44..5c4b6989 100644 > --- a/README.rst > +++ b/README.rst > @@ -58,7 +58,7 @@ Meson Build system: [required] > pip3 install --user --upgrade meson > > for the libcamera core: [required] > - python3-yaml > + python3-yaml python3-ply python3-jinja2 > > for IPA module signing: [required] > libgnutls28-dev openssl > diff --git a/utils/ipc/meson.build b/utils/ipc/meson.build > new file mode 100644 > index 00000000..59f097f0 > --- /dev/null > +++ b/utils/ipc/meson.build > @@ -0,0 +1,3 @@ > +# SPDX-License-Identifier: CC0-1.0 > + > +py_modules += ['jinja2', 'ply'] > diff --git a/utils/meson.build b/utils/meson.build > index 7f2b9b4d..8e28ada7 100644 > --- a/utils/meson.build > +++ b/utils/meson.build > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: CC0-1.0 > > +subdir('ipc') > subdir('ipu3') > subdir('tracepoints') > >
diff --git a/README.rst b/README.rst index f8519b44..5c4b6989 100644 --- a/README.rst +++ b/README.rst @@ -58,7 +58,7 @@ Meson Build system: [required] pip3 install --user --upgrade meson for the libcamera core: [required] - python3-yaml + python3-yaml python3-ply python3-jinja2 for IPA module signing: [required] libgnutls28-dev openssl diff --git a/utils/ipc/meson.build b/utils/ipc/meson.build new file mode 100644 index 00000000..59f097f0 --- /dev/null +++ b/utils/ipc/meson.build @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: CC0-1.0 + +py_modules += ['jinja2', 'ply'] diff --git a/utils/meson.build b/utils/meson.build index 7f2b9b4d..8e28ada7 100644 --- a/utils/meson.build +++ b/utils/meson.build @@ -1,5 +1,6 @@ # SPDX-License-Identifier: CC0-1.0 +subdir('ipc') subdir('ipu3') subdir('tracepoints')