[libcamera-devel,01/11] Install the cam and qcam utilities

Message ID 20190415165700.22970-2-laurent.pinchart@ideasonboard.com
State Superseded
Headers show
Series
  • Rockchip ISP pipeline handler
Related show

Commit Message

Laurent Pinchart April 15, 2019, 4:56 p.m. UTC
The cam and qcam utilities are meant to be shipped with libcamera,
install them by default.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/cam/meson.build  | 1 +
 src/qcam/meson.build | 1 +
 2 files changed, 2 insertions(+)

Comments

Niklas Söderlund April 15, 2019, 8:15 p.m. UTC | #1
Hi Laurent,

Thanks for your work.

On 2019-04-15 19:56:50 +0300, Laurent Pinchart wrote:
> The cam and qcam utilities are meant to be shipped with libcamera,
> install them by default.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/cam/meson.build  | 1 +
>  src/qcam/meson.build | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/src/cam/meson.build b/src/cam/meson.build
> index 1a1244fe25cd..851295091d0d 100644
> --- a/src/cam/meson.build
> +++ b/src/cam/meson.build
> @@ -7,4 +7,5 @@ cam_sources = files([
>  
>  cam  = executable('cam', cam_sources,
>                    link_with : libcamera,
> +                  install : true,
>                    include_directories : libcamera_includes)
> diff --git a/src/qcam/meson.build b/src/qcam/meson.build
> index 3d8b1b3b759d..56b57a266b29 100644
> --- a/src/qcam/meson.build
> +++ b/src/qcam/meson.build
> @@ -16,6 +16,7 @@ qt5_dep = dependency('qt5',
>  if qt5_dep.found()
>      qcam  = executable('qcam', qcam_sources,
>                         link_with : libcamera,
> +                       install : true,
>                         include_directories : libcamera_includes,
>                         dependencies : qt5_dep,
>                         cpp_args : '-DQT_NO_KEYWORDS')
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Jacopo Mondi April 16, 2019, 2:53 p.m. UTC | #2
Hi Laurent,

On Mon, Apr 15, 2019 at 07:56:50PM +0300, Laurent Pinchart wrote:
> The cam and qcam utilities are meant to be shipped with libcamera,
> install them by default.

Thanks,
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  src/cam/meson.build  | 1 +
>  src/qcam/meson.build | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/src/cam/meson.build b/src/cam/meson.build
> index 1a1244fe25cd..851295091d0d 100644
> --- a/src/cam/meson.build
> +++ b/src/cam/meson.build
> @@ -7,4 +7,5 @@ cam_sources = files([
>
>  cam  = executable('cam', cam_sources,
>                    link_with : libcamera,
> +                  install : true,
>                    include_directories : libcamera_includes)
> diff --git a/src/qcam/meson.build b/src/qcam/meson.build
> index 3d8b1b3b759d..56b57a266b29 100644
> --- a/src/qcam/meson.build
> +++ b/src/qcam/meson.build
> @@ -16,6 +16,7 @@ qt5_dep = dependency('qt5',
>  if qt5_dep.found()
>      qcam  = executable('qcam', qcam_sources,
>                         link_with : libcamera,
> +                       install : true,
>                         include_directories : libcamera_includes,
>                         dependencies : qt5_dep,
>                         cpp_args : '-DQT_NO_KEYWORDS')
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/cam/meson.build b/src/cam/meson.build
index 1a1244fe25cd..851295091d0d 100644
--- a/src/cam/meson.build
+++ b/src/cam/meson.build
@@ -7,4 +7,5 @@  cam_sources = files([
 
 cam  = executable('cam', cam_sources,
                   link_with : libcamera,
+                  install : true,
                   include_directories : libcamera_includes)
diff --git a/src/qcam/meson.build b/src/qcam/meson.build
index 3d8b1b3b759d..56b57a266b29 100644
--- a/src/qcam/meson.build
+++ b/src/qcam/meson.build
@@ -16,6 +16,7 @@  qt5_dep = dependency('qt5',
 if qt5_dep.found()
     qcam  = executable('qcam', qcam_sources,
                        link_with : libcamera,
+                       install : true,
                        include_directories : libcamera_includes,
                        dependencies : qt5_dep,
                        cpp_args : '-DQT_NO_KEYWORDS')