| Message ID | 20201023051021.16389-3-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thanks for the patch. On 10/23/20 10:40 AM, Laurent Pinchart wrote: > A few default constructors and destructors are needlessly defined as > empty. Drop them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <email@uajain.com> > --- > include/libcamera/signal.h | 1 - > test/media_device/media_device_print_test.cpp | 4 ---- > 2 files changed, 5 deletions(-) > > diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h > index accb797e911c..5bcd7a77c5f1 100644 > --- a/include/libcamera/signal.h > +++ b/include/libcamera/signal.h > @@ -38,7 +38,6 @@ template<typename... Args> > class Signal : public SignalBase > { > public: > - Signal() {} > ~Signal() > { > disconnect(); > diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp > index 436d4e8af614..cdec5b8da3ec 100644 > --- a/test/media_device/media_device_print_test.cpp > +++ b/test/media_device/media_device_print_test.cpp > @@ -25,10 +25,6 @@ using namespace std; > */ > class MediaDevicePrintTest : public Test > { > -public: > - MediaDevicePrintTest() {} > - ~MediaDevicePrintTest() {} > - > protected: > int init() { return 0; } > int run();
On 23/10/2020 06:10, Laurent Pinchart wrote: > A few default constructors and destructors are needlessly defined as > empty. Drop them. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > include/libcamera/signal.h | 1 - > test/media_device/media_device_print_test.cpp | 4 ---- > 2 files changed, 5 deletions(-) > > diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h > index accb797e911c..5bcd7a77c5f1 100644 > --- a/include/libcamera/signal.h > +++ b/include/libcamera/signal.h > @@ -38,7 +38,6 @@ template<typename... Args> > class Signal : public SignalBase > { > public: > - Signal() {} > ~Signal() > { > disconnect(); > diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp > index 436d4e8af614..cdec5b8da3ec 100644 > --- a/test/media_device/media_device_print_test.cpp > +++ b/test/media_device/media_device_print_test.cpp > @@ -25,10 +25,6 @@ using namespace std; > */ > class MediaDevicePrintTest : public Test > { > -public: > - MediaDevicePrintTest() {} > - ~MediaDevicePrintTest() {} > - > protected: > int init() { return 0; } > int run(); >
diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h index accb797e911c..5bcd7a77c5f1 100644 --- a/include/libcamera/signal.h +++ b/include/libcamera/signal.h @@ -38,7 +38,6 @@ template<typename... Args> class Signal : public SignalBase { public: - Signal() {} ~Signal() { disconnect(); diff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp index 436d4e8af614..cdec5b8da3ec 100644 --- a/test/media_device/media_device_print_test.cpp +++ b/test/media_device/media_device_print_test.cpp @@ -25,10 +25,6 @@ using namespace std; */ class MediaDevicePrintTest : public Test { -public: - MediaDevicePrintTest() {} - ~MediaDevicePrintTest() {} - protected: int init() { return 0; } int run();
A few default constructors and destructors are needlessly defined as empty. Drop them. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- include/libcamera/signal.h | 1 - test/media_device/media_device_print_test.cpp | 4 ---- 2 files changed, 5 deletions(-)