[libcamera-devel,2/9] README: Move the required dependencies to the top
diff mbox series

Message ID 20200923151522.56778-3-ricardo@ribalda.com
State Accepted
Headers show
Series
  • Fix README.rst
Related show

Commit Message

Ricardo Ribalda Sept. 23, 2020, 3:15 p.m. UTC 
Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
---
 README.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Kieran Bingham Sept. 23, 2020, 8:01 p.m. UTC | #1 
Hi Ricardo,

On 23/09/2020 16:15, Ricardo Ribalda wrote:
> Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>

This is a good idea IMO.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  README.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/README.rst b/README.rst
> index 2863326..cfd0be7 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -57,6 +57,9 @@ Meson Build system: [required]
>              pip3 install --user meson
>              pip3 install --user --upgrade meson
>  
> +for IPA module signing: [required]
> +        libgnutls28-dev openssl
> +
>  for device hotplug enumeration: [optional]
>  	pkg-config libudev-dev
>  
> @@ -66,9 +69,6 @@ for documentation: [optional]
>  for gstreamer: [optional]
>  	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
>  
> -for IPA module signing: [required]
> -        libgnutls28-dev openssl
> -
>  for qcam: [optional]
>  	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5
>  
>
Laurent Pinchart Sept. 24, 2020, 2:35 a.m. UTC | #2 
On Wed, Sep 23, 2020 at 09:01:01PM +0100, Kieran Bingham wrote:
> Hi Ricardo,
> 
> On 23/09/2020 16:15, Ricardo Ribalda wrote:
> > Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
> 
> This is a good idea IMO.

I don't mind, but please note that once IPA isolation gets merged, IPA
module signing will become optional again (likely with a config option
that defaults to true as it's highly encouraged to enable it).

> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> > ---
> >  README.rst | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/README.rst b/README.rst
> > index 2863326..cfd0be7 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -57,6 +57,9 @@ Meson Build system: [required]
> >              pip3 install --user meson
> >              pip3 install --user --upgrade meson
> >  
> > +for IPA module signing: [required]
> > +        libgnutls28-dev openssl
> > +
> >  for device hotplug enumeration: [optional]
> >  	pkg-config libudev-dev
> >  
> > @@ -66,9 +69,6 @@ for documentation: [optional]
> >  for gstreamer: [optional]
> >  	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
> >  
> > -for IPA module signing: [required]
> > -        libgnutls28-dev openssl
> > -
> >  for qcam: [optional]
> >  	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5
> >
Kieran Bingham Sept. 24, 2020, 9:06 a.m. UTC | #3 
Hi Laurent,

On 24/09/2020 03:35, Laurent Pinchart wrote:
> On Wed, Sep 23, 2020 at 09:01:01PM +0100, Kieran Bingham wrote:
>> Hi Ricardo,
>>
>> On 23/09/2020 16:15, Ricardo Ribalda wrote:
>>> Signed-off-by: Ricardo Ribalda <ricardo@ribalda.com>
>>
>> This is a good idea IMO.
> 
> I don't mind, but please note that once IPA isolation gets merged, IPA
> module signing will become optional again (likely with a config option
> that defaults to true as it's highly encouraged to enable it).

In this instance, That's ok - as it will then sit happily at the top of
the optional section ;-)

--
Kieran


> 
>> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>>
>>> ---
>>>  README.rst | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/README.rst b/README.rst
>>> index 2863326..cfd0be7 100644
>>> --- a/README.rst
>>> +++ b/README.rst
>>> @@ -57,6 +57,9 @@ Meson Build system: [required]
>>>              pip3 install --user meson
>>>              pip3 install --user --upgrade meson
>>>  
>>> +for IPA module signing: [required]
>>> +        libgnutls28-dev openssl
>>> +
>>>  for device hotplug enumeration: [optional]
>>>  	pkg-config libudev-dev
>>>  
>>> @@ -66,9 +69,6 @@ for documentation: [optional]
>>>  for gstreamer: [optional]
>>>  	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
>>>  
>>> -for IPA module signing: [required]
>>> -        libgnutls28-dev openssl
>>> -
>>>  for qcam: [optional]
>>>  	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5
>>>  
>

Patch
diff mbox series 

diff --git a/README.rst b/README.rst
index 2863326..cfd0be7 100644
--- a/README.rst
+++ b/README.rst
@@ -57,6 +57,9 @@  Meson Build system: [required]
             pip3 install --user meson
             pip3 install --user --upgrade meson
 
+for IPA module signing: [required]
+        libgnutls28-dev openssl
+
 for device hotplug enumeration: [optional]
 	pkg-config libudev-dev
 
@@ -66,9 +69,6 @@  for documentation: [optional]
 for gstreamer: [optional]
 	libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
 
-for IPA module signing: [required]
-        libgnutls28-dev openssl
-
 for qcam: [optional]
 	qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5