Message ID | 20200922095018.68434-1-naush@raspberrypi.com |
---|---|
Headers | show |
Series |
|
Related | show |
Hi Naush, Thank you for the patch. On Tue, Sep 22, 2020 at 10:50:14AM +0100, Naushir Patuck wrote: > Hi, > > This patch set contains some overdue tidying up of the Raspberry Pi > controller, ipa, and pipeline hander code. Mostly moving things into > their own namespace and removing the "RPi" prefix off variable names. > Note there there are no functional changes in any of the 4 patches, > only adding some syntactic sugar :) Very nice cleanup series ! I've glanced over it, and Kieran and Jacopo have already pointed out the small issues I've seen. I'm sure we could bikeshed libcamera::RPi:: vs. IPA::RPi:: (lowercase or uppercase), and while I think the suggestion to create an IPA namespace is interesting, it doesn't necessarily need to be introduced now (unless everyone is convinced). For the whole series, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Naushir Patuck (4): > pipeline: raspberrypi: Move RPiStream and RPiDevice to its own > namespace > ipa: raspberrypi: Move IPA parameters to the RPi namespace > ipa: raspberrypi: Rename the controller namespace from Rpi to > RpiController > ipa: raspberrypi: Tidy up variable names to be consistent > > include/libcamera/ipa/raspberrypi.h | 42 +-- > src/ipa/raspberrypi/cam_helper.cpp | 2 +- > src/ipa/raspberrypi/cam_helper.hpp | 2 +- > src/ipa/raspberrypi/cam_helper_imx219.cpp | 2 +- > src/ipa/raspberrypi/cam_helper_imx477.cpp | 2 +- > src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +- > .../raspberrypi/controller/agc_algorithm.hpp | 4 +- > src/ipa/raspberrypi/controller/algorithm.cpp | 4 +- > src/ipa/raspberrypi/controller/algorithm.hpp | 4 +- > .../raspberrypi/controller/awb_algorithm.hpp | 4 +- > .../raspberrypi/controller/ccm_algorithm.hpp | 4 +- > .../controller/contrast_algorithm.hpp | 4 +- > src/ipa/raspberrypi/controller/controller.cpp | 2 +- > src/ipa/raspberrypi/controller/controller.hpp | 4 +- > src/ipa/raspberrypi/controller/histogram.cpp | 2 +- > src/ipa/raspberrypi/controller/histogram.hpp | 4 +- > src/ipa/raspberrypi/controller/metadata.hpp | 4 +- > src/ipa/raspberrypi/controller/pwl.cpp | 2 +- > src/ipa/raspberrypi/controller/pwl.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/alsc.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +- > .../controller/rpi/black_level.cpp | 2 +- > .../controller/rpi/black_level.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/ccm.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +- > .../raspberrypi/controller/rpi/contrast.cpp | 2 +- > .../raspberrypi/controller/rpi/contrast.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/dpc.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/focus.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/geq.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/geq.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/lux.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/noise.hpp | 4 +- > src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +- > src/ipa/raspberrypi/controller/rpi/sdn.hpp | 4 +- > .../raspberrypi/controller/rpi/sharpen.cpp | 2 +- > .../raspberrypi/controller/rpi/sharpen.hpp | 4 +- > .../controller/sharpen_algorithm.hpp | 4 +- > src/ipa/raspberrypi/md_parser.cpp | 2 +- > src/ipa/raspberrypi/md_parser.hpp | 2 +- > src/ipa/raspberrypi/md_parser_rpi.cpp | 2 +- > src/ipa/raspberrypi/md_parser_rpi.hpp | 2 +- > src/ipa/raspberrypi/raspberrypi.cpp | 256 +++++++++--------- > .../pipeline/raspberrypi/raspberrypi.cpp | 84 +++--- > .../pipeline/raspberrypi/rpi_stream.cpp | 38 +-- > .../pipeline/raspberrypi/rpi_stream.h | 20 +- > 54 files changed, 295 insertions(+), 291 deletions(-)