[libcamera-devel,v2,3/4] src: meson: Rename ipa_gen_priv_key to gen_ipa_priv_key
diff mbox series

Message ID 20200923143949.310439-4-kieran.bingham@ideasonboard.com
State Accepted
Commit 131629d3a25f2e5879b96bdf7fa0377efdc2025b
Headers show
Series
  • Unify utils locations
Related show

Commit Message

Kieran Bingham Sept. 23, 2020, 2:39 p.m. UTC 
Refactor the naming of the custom command variable to match the style
used in the other custom target generators, and the name of the script.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

---
I've chosen to keep this as a separate patch to keep the rename and move
distinct.
---
 src/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Laurent Pinchart Sept. 23, 2020, 4:06 p.m. UTC | #1 
Hi Kieran,

Thank you for the patch.

On Wed, Sep 23, 2020 at 03:39:48PM +0100, Kieran Bingham wrote:
> Refactor the naming of the custom command variable to match the style
> used in the other custom target generators, and the name of the script.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> I've chosen to keep this as a separate patch to keep the rename and move
> distinct.
> ---
>  src/meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/meson.build b/src/meson.build
> index 0c5b64d68c15..db155e68e848 100644
> --- a/src/meson.build
> +++ b/src/meson.build
> @@ -4,10 +4,10 @@ subdir('android')
>  
>  openssl = find_program('openssl', required : true)
>  if openssl.found()
> -    ipa_gen_priv_key = files('ipa/gen-ipa-priv-key.sh')
> +    gen_ipa_priv_key = files('ipa/gen-ipa-priv-key.sh')
>      ipa_priv_key = custom_target('ipa-priv-key',
>                                   output : [ 'ipa-priv-key.pem' ],
> -                                 command : [ ipa_gen_priv_key, '@OUTPUT@' ])
> +                                 command : [ gen_ipa_priv_key, '@OUTPUT@' ])
>      config_h.set('HAVE_IPA_PUBKEY', 1)
>      ipa_sign_module = true
>  else

Patch
diff mbox series 

diff --git a/src/meson.build b/src/meson.build
index 0c5b64d68c15..db155e68e848 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -4,10 +4,10 @@  subdir('android')
 
 openssl = find_program('openssl', required : true)
 if openssl.found()
-    ipa_gen_priv_key = files('ipa/gen-ipa-priv-key.sh')
+    gen_ipa_priv_key = files('ipa/gen-ipa-priv-key.sh')
     ipa_priv_key = custom_target('ipa-priv-key',
                                  output : [ 'ipa-priv-key.pem' ],
-                                 command : [ ipa_gen_priv_key, '@OUTPUT@' ])
+                                 command : [ gen_ipa_priv_key, '@OUTPUT@' ])
     config_h.set('HAVE_IPA_PUBKEY', 1)
     ipa_sign_module = true
 else