[libcamera-devel,v3,0/8] android: camera_device: Add support for internal buffers
mbox series

Message ID 20200921153736.24070-1-jacopo@jmondi.org
Headers show
Series
  • android: camera_device: Add support for internal buffers
Related show

Message

Jacopo Mondi Sept. 21, 2020, 3:37 p.m. UTC 
Minimal changes:
- added Niklas tag
- use switch() instead of if() in 7/8 as suggested by Niklas

I would like to push this if no objections

Thanks
   j


Jacopo Mondi (8):
  android: camera_device: Add CameraStream::Type
  android: camera_device: Add frame allocator
  libcamera: frame_buffer_allocator: Add clear()
  android: camera_device: Clear allocator at configureStream
  android: camera_device: Allocate buffer pools
  android: camera_device: Add methods to get and return buffers
  android: camera_device: Use libcamera buffer pool
  android: camera_device: Add stream mapping log

 include/libcamera/framebuffer_allocator.h |   1 +
 src/android/camera_device.cpp             | 164 +++++++++++++++++++---
 src/android/camera_device.h               | 102 +++++++++++++-
 src/libcamera/framebuffer_allocator.cpp   |   8 ++
 4 files changed, 252 insertions(+), 23 deletions(-)

--
2.28.0

Comments

Laurent Pinchart Sept. 22, 2020, 8:17 a.m. UTC | #1 
Hi Jacopo,

On Mon, Sep 21, 2020 at 05:37:28PM +0200, Jacopo Mondi wrote:
> Minimal changes:
> - added Niklas tag
> - use switch() instead of if() in 7/8 as suggested by Niklas
> 
> I would like to push this if no objections

I only see the cover letter, could we also get the patches ? :-)

> Jacopo Mondi (8):
>   android: camera_device: Add CameraStream::Type
>   android: camera_device: Add frame allocator
>   libcamera: frame_buffer_allocator: Add clear()
>   android: camera_device: Clear allocator at configureStream
>   android: camera_device: Allocate buffer pools
>   android: camera_device: Add methods to get and return buffers
>   android: camera_device: Use libcamera buffer pool
>   android: camera_device: Add stream mapping log
> 
>  include/libcamera/framebuffer_allocator.h |   1 +
>  src/android/camera_device.cpp             | 164 +++++++++++++++++++---
>  src/android/camera_device.h               | 102 +++++++++++++-
>  src/libcamera/framebuffer_allocator.cpp   |   8 ++
>  4 files changed, 252 insertions(+), 23 deletions(-)
Jacopo Mondi Sept. 22, 2020, 9:44 a.m. UTC | #2 
Hi Laurent,

On Tue, Sep 22, 2020 at 11:17:04AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Mon, Sep 21, 2020 at 05:37:28PM +0200, Jacopo Mondi wrote:
> > Minimal changes:
> > - added Niklas tag
> > - use switch() instead of if() in 7/8 as suggested by Niklas
> >
> > I would like to push this if no objections
>
> I only see the cover letter, could we also get the patches ? :-)
>

I hoped you didn't notice and I could merge the series :)

Don't know what happened, the cover letter has the right To: field,
the other patches don't... I'll re-send!

Thanks
  j

> > Jacopo Mondi (8):
> >   android: camera_device: Add CameraStream::Type
> >   android: camera_device: Add frame allocator
> >   libcamera: frame_buffer_allocator: Add clear()
> >   android: camera_device: Clear allocator at configureStream
> >   android: camera_device: Allocate buffer pools
> >   android: camera_device: Add methods to get and return buffers
> >   android: camera_device: Use libcamera buffer pool
> >   android: camera_device: Add stream mapping log
> >
> >  include/libcamera/framebuffer_allocator.h |   1 +
> >  src/android/camera_device.cpp             | 164 +++++++++++++++++++---
> >  src/android/camera_device.h               | 102 +++++++++++++-
> >  src/libcamera/framebuffer_allocator.cpp   |   8 ++
> >  4 files changed, 252 insertions(+), 23 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart