| Message ID | 20200916145254.1644-2-laurent.pinchart@ideasonboard.com |
|---|---|
| State | Accepted |
| Commit | 11abf52a8ac521c40e306cc3113426606dcc3000 |
| Headers | show |
| Series |
|
| Related | show |
Hi Laurent, Thanks for your work. On 2020-09-16 17:52:48 +0300, Laurent Pinchart wrote: > There's no need to prefix files in the local directory with './'. Drop > it. > > While at it, add indentation to make the *.qrc files more readable. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/qcam/assets/feathericons/feathericons.qrc | 12 ++++++------ > src/qcam/assets/shader/shaders.qrc | 8 ++++---- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/src/qcam/assets/feathericons/feathericons.qrc b/src/qcam/assets/feathericons/feathericons.qrc > index 656f2b463511..c5302040ea44 100644 > --- a/src/qcam/assets/feathericons/feathericons.qrc > +++ b/src/qcam/assets/feathericons/feathericons.qrc > @@ -1,11 +1,11 @@ > <!-- SPDX-License-Identifier: GPL-2.0-or-later --> > <!DOCTYPE RCC><RCC version="1.0"> > <qresource> > -<file>./aperture.svg</file> > -<file>./camera-off.svg</file> > -<file>./play-circle.svg</file> > -<file>./save.svg</file> > -<file>./stop-circle.svg</file> > -<file>./x-circle.svg</file> > + <file>aperture.svg</file> > + <file>camera-off.svg</file> > + <file>play-circle.svg</file> > + <file>save.svg</file> > + <file>stop-circle.svg</file> > + <file>x-circle.svg</file> > </qresource> > </RCC> > diff --git a/src/qcam/assets/shader/shaders.qrc b/src/qcam/assets/shader/shaders.qrc > index 33eab2780d5e..9ae35c9f70d6 100644 > --- a/src/qcam/assets/shader/shaders.qrc > +++ b/src/qcam/assets/shader/shaders.qrc > @@ -1,9 +1,9 @@ > <!-- SPDX-License-Identifier: LGPL-2.1-or-later --> > <!DOCTYPE RCC><RCC version="1.0"> > <qresource> > -<file>./NV_vertex_shader.glsl</file> > -<file>./NV_2_planes_UV_f.glsl</file> > -<file>./NV_2_planes_VU_f.glsl</file> > -<file>./NV_3_planes_f.glsl</file> > + <file>NV_vertex_shader.glsl</file> > + <file>NV_2_planes_UV_f.glsl</file> > + <file>NV_2_planes_VU_f.glsl</file> > + <file>NV_3_planes_f.glsl</file> > </qresource> > </RCC> > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/src/qcam/assets/feathericons/feathericons.qrc b/src/qcam/assets/feathericons/feathericons.qrc index 656f2b463511..c5302040ea44 100644 --- a/src/qcam/assets/feathericons/feathericons.qrc +++ b/src/qcam/assets/feathericons/feathericons.qrc @@ -1,11 +1,11 @@ <!-- SPDX-License-Identifier: GPL-2.0-or-later --> <!DOCTYPE RCC><RCC version="1.0"> <qresource> -<file>./aperture.svg</file> -<file>./camera-off.svg</file> -<file>./play-circle.svg</file> -<file>./save.svg</file> -<file>./stop-circle.svg</file> -<file>./x-circle.svg</file> + <file>aperture.svg</file> + <file>camera-off.svg</file> + <file>play-circle.svg</file> + <file>save.svg</file> + <file>stop-circle.svg</file> + <file>x-circle.svg</file> </qresource> </RCC> diff --git a/src/qcam/assets/shader/shaders.qrc b/src/qcam/assets/shader/shaders.qrc index 33eab2780d5e..9ae35c9f70d6 100644 --- a/src/qcam/assets/shader/shaders.qrc +++ b/src/qcam/assets/shader/shaders.qrc @@ -1,9 +1,9 @@ <!-- SPDX-License-Identifier: LGPL-2.1-or-later --> <!DOCTYPE RCC><RCC version="1.0"> <qresource> -<file>./NV_vertex_shader.glsl</file> -<file>./NV_2_planes_UV_f.glsl</file> -<file>./NV_2_planes_VU_f.glsl</file> -<file>./NV_3_planes_f.glsl</file> + <file>NV_vertex_shader.glsl</file> + <file>NV_2_planes_UV_f.glsl</file> + <file>NV_2_planes_VU_f.glsl</file> + <file>NV_3_planes_f.glsl</file> </qresource> </RCC>
There's no need to prefix files in the local directory with './'. Drop it. While at it, add indentation to make the *.qrc files more readable. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- src/qcam/assets/feathericons/feathericons.qrc | 12 ++++++------ src/qcam/assets/shader/shaders.qrc | 8 ++++---- 2 files changed, 10 insertions(+), 10 deletions(-)