| Message ID | 20200804122755.30743-1-email@uajain.com |
|---|---|
| State | Accepted |
| Commit | aea5ace7c3f40450094fdc9ec66cadc9465eea4c |
| Headers | show |
| Series |
|
| Related | show |
Hi Umang, Thanks for your work. On 2020-08-04 12:28:01 +0000, Umang Jain wrote: > The CameraHalManager::getStaticMethod() method isn't used, remove it. > > Signed-off-by: Umang Jain <email@uajain.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/android/camera_hal_manager.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h > index 94d8f00..0619037 100644 > --- a/src/android/camera_hal_manager.h > +++ b/src/android/camera_hal_manager.h > @@ -31,8 +31,6 @@ public: > int getCameraInfo(unsigned int id, struct camera_info *info); > > private: > - camera_metadata_t *getStaticMetadata(unsigned int id); > - > libcamera::CameraManager *cameraManager_; > > std::vector<std::unique_ptr<CameraDevice>> cameras_; > -- > 2.26.2 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Umang, On 04/08/2020 13:28, Umang Jain wrote: > The CameraHalManager::getStaticMethod() method isn't used, remove it. > > Signed-off-by: Umang Jain <email@uajain.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/android/camera_hal_manager.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h > index 94d8f00..0619037 100644 > --- a/src/android/camera_hal_manager.h > +++ b/src/android/camera_hal_manager.h > @@ -31,8 +31,6 @@ public: > int getCameraInfo(unsigned int id, struct camera_info *info); > > private: > - camera_metadata_t *getStaticMetadata(unsigned int id); > - > libcamera::CameraManager *cameraManager_; > > std::vector<std::unique_ptr<CameraDevice>> cameras_; >
Hi Umang, On Tue, Aug 04, 2020 at 03:23:56PM +0200, Niklas Söderlund wrote: > Hi Umang, > > Thanks for your work. > > On 2020-08-04 12:28:01 +0000, Umang Jain wrote: > > The CameraHalManager::getStaticMethod() method isn't used, remove it. > > > > Signed-off-by: Umang Jain <email@uajain.com> > > Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Sorry, leftover indeed! Acked-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > > > --- > > src/android/camera_hal_manager.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h > > index 94d8f00..0619037 100644 > > --- a/src/android/camera_hal_manager.h > > +++ b/src/android/camera_hal_manager.h > > @@ -31,8 +31,6 @@ public: > > int getCameraInfo(unsigned int id, struct camera_info *info); > > > > private: > > - camera_metadata_t *getStaticMetadata(unsigned int id); > > - > > libcamera::CameraManager *cameraManager_; > > > > std::vector<std::unique_ptr<CameraDevice>> cameras_; > > -- > > 2.26.2 > > > > _______________________________________________ > > libcamera-devel mailing list > > libcamera-devel@lists.libcamera.org > > https://lists.libcamera.org/listinfo/libcamera-devel > > -- > Regards, > Niklas Söderlund > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h index 94d8f00..0619037 100644 --- a/src/android/camera_hal_manager.h +++ b/src/android/camera_hal_manager.h @@ -31,8 +31,6 @@ public: int getCameraInfo(unsigned int id, struct camera_info *info); private: - camera_metadata_t *getStaticMetadata(unsigned int id); - libcamera::CameraManager *cameraManager_; std::vector<std::unique_ptr<CameraDevice>> cameras_;
The CameraHalManager::getStaticMethod() method isn't used, remove it. Signed-off-by: Umang Jain <email@uajain.com> --- src/android/camera_hal_manager.h | 2 -- 1 file changed, 2 deletions(-)