| Message ID | 20200630135804.830536-1-andrewsh@debian.org |
|---|---|
| State | Accepted |
| Commit | 8dbd0049e0f96d9af1c37d88cba523b2fef55bbc |
| Headers | show |
| Series |
|
| Related | show |
Hi Andrej, On 30/06/2020 14:58, Andrej Shadura wrote: > From: IOhannes m zmölnig <umlaeute@debian.org> Is this correct? It looks corrupted in my e-mail. > > Fix a typo in the word "unknown". > > Signed-off-by: Andrej Shadura <andrewsh@debian.org> We require a Signed-off-by: from the Author, which is marked as umlaeute@debian.org in the header here. Have you authored this patch ? Or are you forwarding on from someone else? For the actual content of the patch: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/ipa/rkisp1/rkisp1.cpp | 2 +- > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > index fbdc908..bfd76cf 100644 > --- a/src/ipa/rkisp1/rkisp1.cpp > +++ b/src/ipa/rkisp1/rkisp1.cpp > @@ -176,7 +176,7 @@ void IPARkISP1::processEvent(const IPAOperationData &event) > break; > } > default: > - LOG(IPARkISP1, Error) << "Unkown event " << event.operation; > + LOG(IPARkISP1, Error) << "Unknown event " << event.operation; > break; > } > } > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > index 3c01821..3c3f3f3 100644 > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > @@ -429,7 +429,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame, > metadataReady(frame, action.controls[0]); > break; > default: > - LOG(RkISP1, Error) << "Unkown action " << action.operation; > + LOG(RkISP1, Error) << "Unknown action " << action.operation; > break; > } > } > > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel >
. On Tue, 30 Jun 2020 at 16:22, Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > > Hi Andrej, > > On 30/06/2020 14:58, Andrej Shadura wrote: > > From: IOhannes m zmölnig <umlaeute@debian.org> > > Is this correct? It looks corrupted in my e-mail. It was supposed to be IOhannes m zmölnig. I guess UTF-8 has got mangled into Latin-1. > > Fix a typo in the word "unknown". > > > > Signed-off-by: Andrej Shadura <andrewsh@debian.org> > > We require a Signed-off-by: from the Author, which is marked as > umlaeute@debian.org in the header here. > > Have you authored this patch ? Or are you forwarding on from someone else? IOhannes and I are co-maintainers of libcamera in Debian. He wrote this patch and I’m forwarding it for him. He didn’t leave a sign-off, but since this patch is trivial and arguably non-copyrightable, I understand this should not be a problem (I can "re-author" it myself or so can you). In fact, I wrote the patch description in its entirely, so in a way I wrote more of the patch than he did :) > For the actual content of the patch: > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > --- > > src/ipa/rkisp1/rkisp1.cpp | 2 +- > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > > index fbdc908..bfd76cf 100644 > > --- a/src/ipa/rkisp1/rkisp1.cpp > > +++ b/src/ipa/rkisp1/rkisp1.cpp > > @@ -176,7 +176,7 @@ void IPARkISP1::processEvent(const IPAOperationData &event) > > break; > > } > > default: > > - LOG(IPARkISP1, Error) << "Unkown event " << event.operation; > > + LOG(IPARkISP1, Error) << "Unknown event " << event.operation; > > break; > > } > > } > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > index 3c01821..3c3f3f3 100644 > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > @@ -429,7 +429,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame, > > metadataReady(frame, action.controls[0]); > > break; > > default: > > - LOG(RkISP1, Error) << "Unkown action " << action.operation; > > + LOG(RkISP1, Error) << "Unknown action " << action.operation; > > break; > > } > > } > > > > > > _______________________________________________ > > libcamera-devel mailing list > > libcamera-devel@lists.libcamera.org > > https://lists.libcamera.org/listinfo/libcamera-devel > > > > -- > Regards > -- > Kieran
On Tue, 30 Jun 2020 at 16:31, Andrej Shadura <andrewsh@debian.org> wrote: > On Tue, 30 Jun 2020 at 16:22, Kieran Bingham > <kieran.bingham@ideasonboard.com> wrote: > > On 30/06/2020 14:58, Andrej Shadura wrote: > > > Signed-off-by: Andrej Shadura <andrewsh@debian.org> > > We require a Signed-off-by: from the Author, which is marked as > > umlaeute@debian.org in the header here. > > Have you authored this patch ? Or are you forwarding on from someone else? > > IOhannes and I are co-maintainers of libcamera in Debian. He wrote > this patch and I’m forwarding it for him. He didn’t leave a sign-off, > but since this patch is trivial and arguably non-copyrightable, I > understand this should not be a problem (I can "re-author" it myself > or so can you). In fact, I wrote the patch description in its > entirely, so in a way I wrote more of the patch than he did :) Or I could simply cc him and let him provide the missing sign-off :) > > For the actual content of the patch: > > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > --- > > > src/ipa/rkisp1/rkisp1.cpp | 2 +- > > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > > > index fbdc908..bfd76cf 100644 > > > --- a/src/ipa/rkisp1/rkisp1.cpp > > > +++ b/src/ipa/rkisp1/rkisp1.cpp > > > @@ -176,7 +176,7 @@ void IPARkISP1::processEvent(const IPAOperationData &event) > > > break; > > > } > > > default: > > > - LOG(IPARkISP1, Error) << "Unkown event " << event.operation; > > > + LOG(IPARkISP1, Error) << "Unknown event " << event.operation; > > > break; > > > } > > > } > > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > > index 3c01821..3c3f3f3 100644 > > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > > @@ -429,7 +429,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame, > > > metadataReady(frame, action.controls[0]); > > > break; > > > default: > > > - LOG(RkISP1, Error) << "Unkown action " << action.operation; > > > + LOG(RkISP1, Error) << "Unknown action " << action.operation; > > > break; > > > } > > > }
Hi Kieran, On Tue, Jun 30, 2020 at 03:15:49PM +0100, Kieran Bingham wrote: > On 30/06/2020 14:58, Andrej Shadura wrote: > > From: IOhannes m zmölnig <umlaeute@debian.org> I'd blame your mail client (or possibly server), it looked good on my side before you replied :-) > Is this correct? It looks corrupted in my e-mail. > > > > > Fix a typo in the word "unknown". > > > > Signed-off-by: Andrej Shadura <andrewsh@debian.org> > > We require a Signed-off-by: from the Author, which is marked as > umlaeute@debian.org in the header here. > > Have you authored this patch ? Or are you forwarding on from someone else? > > > For the actual content of the patch: > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > --- > > src/ipa/rkisp1/rkisp1.cpp | 2 +- > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > > index fbdc908..bfd76cf 100644 > > --- a/src/ipa/rkisp1/rkisp1.cpp > > +++ b/src/ipa/rkisp1/rkisp1.cpp > > @@ -176,7 +176,7 @@ void IPARkISP1::processEvent(const IPAOperationData &event) > > break; > > } > > default: > > - LOG(IPARkISP1, Error) << "Unkown event " << event.operation; > > + LOG(IPARkISP1, Error) << "Unknown event " << event.operation; > > break; > > } > > } > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > index 3c01821..3c3f3f3 100644 > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > @@ -429,7 +429,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame, > > metadataReady(frame, action.controls[0]); > > break; > > default: > > - LOG(RkISP1, Error) << "Unkown action " << action.operation; > > + LOG(RkISP1, Error) << "Unknown action " << action.operation; > > break; > > } > > }
On Tue, Jun 30, 2020 at 06:02:44PM +0300, Laurent Pinchart wrote: > Hi Kieran, > > On Tue, Jun 30, 2020 at 03:15:49PM +0100, Kieran Bingham wrote: > > On 30/06/2020 14:58, Andrej Shadura wrote: > > > From: IOhannes m zmölnig <umlaeute@debian.org> > > I'd blame your mail client (or possibly server), it looked good on my > side before you replied :-) Or actually not, the original e-mail didn't specify a charset. > > Is this correct? It looks corrupted in my e-mail. > > > > > > > > Fix a typo in the word "unknown". > > > > > > Signed-off-by: Andrej Shadura <andrewsh@debian.org> > > > > We require a Signed-off-by: from the Author, which is marked as > > umlaeute@debian.org in the header here. > > > > Have you authored this patch ? Or are you forwarding on from someone else? > > > > > > For the actual content of the patch: > > > > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > > > --- > > > src/ipa/rkisp1/rkisp1.cpp | 2 +- > > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp > > > index fbdc908..bfd76cf 100644 > > > --- a/src/ipa/rkisp1/rkisp1.cpp > > > +++ b/src/ipa/rkisp1/rkisp1.cpp > > > @@ -176,7 +176,7 @@ void IPARkISP1::processEvent(const IPAOperationData &event) > > > break; > > > } > > > default: > > > - LOG(IPARkISP1, Error) << "Unkown event " << event.operation; > > > + LOG(IPARkISP1, Error) << "Unknown event " << event.operation; > > > break; > > > } > > > } > > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > > index 3c01821..3c3f3f3 100644 > > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp > > > @@ -429,7 +429,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame, > > > metadataReady(frame, action.controls[0]); > > > break; > > > default: > > > - LOG(RkISP1, Error) << "Unkown action " << action.operation; > > > + LOG(RkISP1, Error) << "Unknown action " << action.operation; > > > break; > > > } > > > }
Hi Andrej On 30/06/2020 15:35, Andrej Shadura wrote: > On Tue, 30 Jun 2020 at 16:31, Andrej Shadura <andrewsh@debian.org> wrote: >> On Tue, 30 Jun 2020 at 16:22, Kieran Bingham >> <kieran.bingham@ideasonboard.com> wrote: >>> On 30/06/2020 14:58, Andrej Shadura wrote: >>>> Signed-off-by: Andrej Shadura <andrewsh@debian.org> > >>> We require a Signed-off-by: from the Author, which is marked as >>> umlaeute@debian.org in the header here. > >>> Have you authored this patch ? Or are you forwarding on from someone else? >> >> IOhannes and I are co-maintainers of libcamera in Debian. He wrote Ahh excellent, welcome to the project, and thanks for your help. >> this patch and I’m forwarding it for him. He didn’t leave a sign-off, >> but since this patch is trivial and arguably non-copyrightable, I Agreed in this case, it's trivial. It's just the missing SoB was noticable ;) >> understand this should not be a problem (I can "re-author" it myself >> or so can you). In fact, I wrote the patch description in its >> entirely, so in a way I wrote more of the patch than he did :) > > Or I could simply cc him and let him provide the missing sign-off :) Either option is good for me. Just a reply here will do in either case and we can update it while applying :-) > >>> For the actual content of the patch: >>> >>> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >>> >>>> --- >>>> src/ipa/rkisp1/rkisp1.cpp | 2 +- >>>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +- >>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp >>>> index fbdc908..bfd76cf 100644 >>>> --- a/src/ipa/rkisp1/rkisp1.cpp >>>> +++ b/src/ipa/rkisp1/rkisp1.cpp >>>> @@ -176,7 +176,7 @@ void IPARkISP1::processEvent(const IPAOperationData &event) >>>> break; >>>> } >>>> default: >>>> - LOG(IPARkISP1, Error) << "Unkown event " << event.operation; >>>> + LOG(IPARkISP1, Error) << "Unknown event " << event.operation; >>>> break; >>>> } >>>> } >>>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp >>>> index 3c01821..3c3f3f3 100644 >>>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp >>>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp >>>> @@ -429,7 +429,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame, >>>> metadataReady(frame, action.controls[0]); >>>> break; >>>> default: >>>> - LOG(RkISP1, Error) << "Unkown action " << action.operation; >>>> + LOG(RkISP1, Error) << "Unknown action " << action.operation; >>>> break; >>>> } >>>> } >
On 2020-07-01 11:43, Kieran Bingham wrote: > Either option is good for me. > > Just a reply here will do in either case and we can update it while > applying :-) please go ahead without my Sign-Off (in this trivial case). gfamdsr IOhannes
diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index fbdc908..bfd76cf 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -176,7 +176,7 @@ void IPARkISP1::processEvent(const IPAOperationData &event) break; } default: - LOG(IPARkISP1, Error) << "Unkown event " << event.operation; + LOG(IPARkISP1, Error) << "Unknown event " << event.operation; break; } } diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 3c01821..3c3f3f3 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -429,7 +429,7 @@ void RkISP1CameraData::queueFrameAction(unsigned int frame, metadataReady(frame, action.controls[0]); break; default: - LOG(RkISP1, Error) << "Unkown action " << action.operation; + LOG(RkISP1, Error) << "Unknown action " << action.operation; break; } }