Message ID | 20200628155539.29498-4-jacopo@jmondi.org |
---|---|
State | Accepted |
Commit | a3e6c2b3d9f4ede89328622fd1087029d0576b76 |
Headers | show |
Series |
|
Related | show |
Hi Jacopo, Thanks for your fix. On 2020-06-28 17:55:39 +0200, Jacopo Mondi wrote: > Fix wrong parameter indent in generateConfiguration() function > implementation. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index cbf19793c43e..1bdad209de6e 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -289,7 +289,7 @@ PipelineHandlerIPU3::PipelineHandlerIPU3(CameraManager *manager) > } > > CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera, > - const StreamRoles &roles) > + const StreamRoles &roles) > { > IPU3CameraData *data = cameraData(camera); > IPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data); > -- > 2.27.0 > > _______________________________________________ > libcamera-devel mailing list > libcamera-devel@lists.libcamera.org > https://lists.libcamera.org/listinfo/libcamera-devel
Hi Jacopo, Thank you for the patch. On Sun, Jun 28, 2020 at 05:55:39PM +0200, Jacopo Mondi wrote: > Fix wrong parameter indent in generateConfiguration() function > implementation. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index cbf19793c43e..1bdad209de6e 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -289,7 +289,7 @@ PipelineHandlerIPU3::PipelineHandlerIPU3(CameraManager *manager) > } > > CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera, > - const StreamRoles &roles) > + const StreamRoles &roles) It may have been done on purpose to shorten the line. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > { > IPU3CameraData *data = cameraData(camera); > IPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data);
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index cbf19793c43e..1bdad209de6e 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -289,7 +289,7 @@ PipelineHandlerIPU3::PipelineHandlerIPU3(CameraManager *manager) } CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera, - const StreamRoles &roles) + const StreamRoles &roles) { IPU3CameraData *data = cameraData(camera); IPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data);
Fix wrong parameter indent in generateConfiguration() function implementation. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)