| Message ID | 20181222230041.29999-3-niklas.soderlund@ragnatech.se |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Niklas, Thank you for the patch. On Sunday, 23 December 2018 01:00:31 EET Niklas Söderlund wrote: > The device enumeration will depend on libudev, add the dependency to the > build system. This should be turned into a optional dependency once a > device enumerator not using udev is supported. > > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> I would have squashed this with the patch that adds the code depending on libudev. In either case, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/meson.build | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build > index 46591069aa5f8beb..52b556a8ed4050cb 100644 > --- a/src/libcamera/meson.build > +++ b/src/libcamera/meson.build > @@ -16,7 +16,10 @@ includes = [ > libcamera_internal_includes, > ] > > +libudev = dependency('libudev') > + > libcamera = shared_library('camera', > libcamera_sources, > install : true, > - include_directories : includes) > + include_directories : includes, > + dependencies : libudev)
diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build index 46591069aa5f8beb..52b556a8ed4050cb 100644 --- a/src/libcamera/meson.build +++ b/src/libcamera/meson.build @@ -16,7 +16,10 @@ includes = [ libcamera_internal_includes, ] +libudev = dependency('libudev') + libcamera = shared_library('camera', libcamera_sources, install : true, - include_directories : includes) + include_directories : includes, + dependencies : libudev)
The device enumeration will depend on libudev, add the dependency to the build system. This should be turned into a optional dependency once a device enumerator not using udev is supported. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> --- src/libcamera/meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)