| Message ID | 20190228200410.3022-11-jacopo@jmondi.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, Thank you for the patch. On Thu, Feb 28, 2019 at 09:04:10PM +0100, Jacopo Mondi wrote: > Now that images come from the ImgU output, hardcode NV12 as default > output format. Would it make sense to squash this with 04/12, as that's where you propagate formats ? It's not a big deal though, as in any case the patch series breaks bisection. It would be nice not to, but that could only be achieved by squashing most of the patches together, which is likely not the best idea. > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp > index 3138eb0bf8b6..660c00dacb2f 100644 > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp > @@ -187,7 +187,7 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera, > V4L2Subdevice *sensor = data->cio2.sensor; > StreamConfiguration *config = &configs[&data->stream_]; > > - config->pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10; > + config->pixelFormat = V4L2_PIX_FMT_NV12; > config->bufferCount = IPU3_BUF_NUM; > > /*
diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index 3138eb0bf8b6..660c00dacb2f 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -187,7 +187,7 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera, V4L2Subdevice *sensor = data->cio2.sensor; StreamConfiguration *config = &configs[&data->stream_]; - config->pixelFormat = V4L2_PIX_FMT_IPU3_SGRBG10; + config->pixelFormat = V4L2_PIX_FMT_NV12; config->bufferCount = IPU3_BUF_NUM; /*
Now that images come from the ImgU output, hardcode NV12 as default output format. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)