Patch Detail
Show a patch.
GET /api/patches/9982/?format=api
{ "id": 9982, "url": "https://patchwork.libcamera.org/api/patches/9982/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9982/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201006144432.22908-14-jacopo@jmondi.org>", "date": "2020-10-06T14:44:32", "name": "[libcamera-devel,v2,13/13] android: camera_device: Clear streams_ at stop time", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dac320b60160eb42ee7ff02a2e1a46f7877e950e", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9982/mbox/", "series": [ { "id": 1356, "url": "https://patchwork.libcamera.org/api/series/1356/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1356", "date": "2020-10-06T14:44:19", "name": "CameraStream refactor", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1356/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9982/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9982/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F974BEEDF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Oct 2020 14:40:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C1E663CD7;\n\tTue, 6 Oct 2020 16:40:54 +0200 (CEST)", "from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B8D363C9B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Oct 2020 16:40:52 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 0C9E960007;\n\tTue, 6 Oct 2020 14:40:51 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 6 Oct 2020 16:44:32 +0200", "Message-Id": "<20201006144432.22908-14-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201006144432.22908-1-jacopo@jmondi.org>", "References": "<20201006144432.22908-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 13/13] android: camera_device: Clear\n\tstreams_ at stop time", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the CameraDevice is stopped, we need to clear the vector\nof CameraStream instances to make sure they get deleted and all the\nresources they have acquired get released.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 58a9f44db219..8da70e817b46 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -517,6 +517,8 @@ int CameraDevice::open(const hw_module_t *hardwareModule)\n \n void CameraDevice::close()\n {\n+\tstreams_.clear();\n+\n \tcamera_->stop();\n \tcamera_->release();\n \n", "prefixes": [ "libcamera-devel", "v2", "13/13" ] }