Patch Detail
Show a patch.
GET /api/patches/9927/?format=api
{ "id": 9927, "url": "https://patchwork.libcamera.org/api/patches/9927/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9927/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201002143154.468162-20-paul.elder@ideasonboard.com>", "date": "2020-10-02T14:31:35", "name": "[libcamera-devel,v3,19/38] libcamera: PipelineHandler: Remove IPA from base class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d1b76f38aaf050851fba598c046625616ae76434", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9927/mbox/", "series": [ { "id": 1348, "url": "https://patchwork.libcamera.org/api/series/1348/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1348", "date": "2020-10-02T14:31:16", "name": "IPA isolation implementation", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1348/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9927/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9927/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7187AC3B5C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Oct 2020 14:32:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F56863B98;\n\tFri, 2 Oct 2020 16:32:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5656563B98\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Oct 2020 16:32:53 +0200 (CEST)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 425602A2;\n\tFri, 2 Oct 2020 16:32:50 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uRiBHuIh\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601649173;\n\tbh=fK5Vjs9cnu2vAvz0e9Ui4IOvN79/pOjLAmoEeROM1g4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uRiBHuIhO97guOPOQ/1sCTbA2EsIEZ1EORMuuGYtZ+vnDyujT2Ef2EUAANDqZG5Ph\n\tyWbJZkRVpTmi7O24u1I+/I+6DPI3CJX/26gCHVPXNuJpYjfkn9r4ljWsLQcffe5YNZ\n\tStnHydIHBc69ip05bEbSWnQz18m7hWkNGcbMtpwQ=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Oct 2020 23:31:35 +0900", "Message-Id": "<20201002143154.468162-20-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201002143154.468162-1-paul.elder@ideasonboard.com>", "References": "<20201002143154.468162-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 19/38] libcamera: PipelineHandler:\n\tRemove IPA from base class", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since pipline handlers now have their own IPA interface types, it can no\nlonger be defined in the base class, and each pipline handler\nimplementation must declare it and its type themselves. Remove it from\nthe base class.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n---\nNo change in v3\n\nChanges in v2:\n- remove documentation\n---\n include/libcamera/internal/pipeline_handler.h | 1 -\n src/libcamera/pipeline_handler.cpp | 8 --------\n 2 files changed, 9 deletions(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex a4e1b529..2018bef0 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -47,7 +47,6 @@ public:\n \tstd::list<Request *> queuedRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n-\tstd::unique_ptr<IPAProxy> ipa_;\n \n private:\n \tCameraData(const CameraData &) = delete;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 894200ee..b893b0e7 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -106,14 +106,6 @@ LOG_DEFINE_CATEGORY(Pipeline)\n * when creating the camera, and shall not be modified afterwards.\n */\n \n-/**\n- * \\var CameraData::ipa_\n- * \\brief The IPA module used by the camera\n- *\n- * Reference to the Image Processing Algorithms (IPA) operating on the camera's\n- * stream(s). If no IPA exists for the camera, this field is set to nullptr.\n- */\n-\n /**\n * \\class PipelineHandler\n * \\brief Create and manage cameras based on a set of media devices\n", "prefixes": [ "libcamera-devel", "v3", "19/38" ] }