Patch Detail
Show a patch.
GET /api/patches/9886/?format=api
{ "id": 9886, "url": "https://patchwork.libcamera.org/api/patches/9886/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9886/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200930200831.2066751-5-niklas.soderlund@ragnatech.se>", "date": "2020-09-30T20:08:29", "name": "[libcamera-devel,4/6] libcamera: pipeline: rkisp1: Add support for R8", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0073dfe44142c144d6397376d2996cfcdfb2dc97", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9886/mbox/", "series": [ { "id": 1341, "url": "https://patchwork.libcamera.org/api/series/1341/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1341", "date": "2020-09-30T20:08:25", "name": "libcamera: pipeline: rkisp1: Refresh to match upstream", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1341/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9886/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9886/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C46FC3B5E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 30 Sep 2020 20:08:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 080D7623C2;\n\tWed, 30 Sep 2020 22:08:46 +0200 (CEST)", "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DE39622E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 30 Sep 2020 22:08:41 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid b899d87b-0358-11eb-b295-0050569116f7;\n\tWed, 30 Sep 2020 22:08:35 +0200 (CEST)" ], "X-Halon-ID": "b899d87b-0358-11eb-b295-0050569116f7", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 30 Sep 2020 22:08:29 +0200", "Message-Id": "<20200930200831.2066751-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200930200831.2066751-1-niklas.soderlund@ragnatech.se>", "References": "<20200930200831.2066751-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 4/6] libcamera: pipeline: rkisp1: Add\n\tsupport for R8", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Both the main and self path supports R8, list it as a supported format.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex 277aa226fcd428be..ff995286073db2a3 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -207,23 +207,25 @@ void RkISP1Path::stop()\n namespace {\n constexpr Size RKISP1_RSZ_MP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_MP_SRC_MAX{ 4416, 3312 };\n-constexpr std::array<PixelFormat, 5> RKISP1_RSZ_MP_FORMATS{\n+constexpr std::array<PixelFormat, 6> RKISP1_RSZ_MP_FORMATS{\n \tformats::YUYV,\n \tformats::NV16,\n \tformats::NV61,\n \tformats::NV21,\n \tformats::NV12,\n-\t/* \\todo Add support for 8-bit greyscale to DRM formats */\n+\tformats::R8,\n+\t/* \\todo Add support for RAW formats. */\n };\n \n constexpr Size RKISP1_RSZ_SP_SRC_MIN{ 32, 16 };\n constexpr Size RKISP1_RSZ_SP_SRC_MAX{ 1920, 1920 };\n-constexpr std::array<PixelFormat, 6> RKISP1_RSZ_SP_FORMATS{\n+constexpr std::array<PixelFormat, 7> RKISP1_RSZ_SP_FORMATS{\n \tformats::YUYV,\n \tformats::NV16,\n \tformats::NV61,\n \tformats::NV21,\n \tformats::NV12,\n+\tformats::R8,\n \tformats::RGB565,\n \t/* \\todo Add support for BGR888 */\n };\n", "prefixes": [ "libcamera-devel", "4/6" ] }