Patch Detail
Show a patch.
GET /api/patches/9849/?format=api
{ "id": 9849, "url": "https://patchwork.libcamera.org/api/patches/9849/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9849/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200929014334.49719-5-niklas.soderlund@ragnatech.se>", "date": "2020-09-29T01:43:31", "name": "[libcamera-devel,v4,4/7] libcamera: pipeline: rkisp1: Add wrappers for accessing the path video device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6f4a204320c98b74a2f08a309c5d6f15de530871", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/9849/mbox/", "series": [ { "id": 1333, "url": "https://patchwork.libcamera.org/api/series/1333/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1333", "date": "2020-09-29T01:43:27", "name": "libcamera: pipeline: rkisp1: Create RkISP1Path helper", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1333/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9849/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9849/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13988C3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Sep 2020 01:43:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E240062150;\n\tTue, 29 Sep 2020 03:43:55 +0200 (CEST)", "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC0CD62033\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Sep 2020 03:43:53 +0200 (CEST)", "from bismarck.berto.se (p54ac52a8.dip0.t-ipconnect.de\n\t[84.172.82.168]) by bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 38536656-01f5-11eb-b295-0050569116f7;\n\tTue, 29 Sep 2020 03:43:50 +0200 (CEST)" ], "X-Halon-ID": "38536656-01f5-11eb-b295-0050569116f7", "Authorized-sender": "niklas.soderlund@fsdn.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 29 Sep 2020 03:43:31 +0200", "Message-Id": "<20200929014334.49719-5-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200929014334.49719-1-niklas.soderlund@ragnatech.se>", "References": "<20200929014334.49719-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 4/7] libcamera: pipeline: rkisp1: Add\n\twrappers for accessing the path video device", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As a step to be able to make RkISP1Path::video_ private add simple\nwrappers for buffer handling. There is no functional change.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n* Changes since v3\n- Inline exportBuffers().\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 12 ++++++------\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 13 ++++++++++++-\n 2 files changed, 18 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 6c81faa818e2b11a..7823fd91866a473a 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -403,10 +403,10 @@ protected:\n \t\tpipe_->stat_->queueBuffer(info->statBuffer);\n \n \t\tif (info->mainPathBuffer)\n-\t\t\tpipe_->mainPath_.video_->queueBuffer(info->mainPathBuffer);\n+\t\t\tpipe_->mainPath_.queueBuffer(info->mainPathBuffer);\n \n \t\tif (info->selfPathBuffer)\n-\t\t\tpipe_->selfPath_.video_->queueBuffer(info->selfPathBuffer);\n+\t\t\tpipe_->selfPath_.queueBuffer(info->selfPathBuffer);\n \t}\n \n private:\n@@ -747,9 +747,9 @@ int PipelineHandlerRkISP1::exportFrameBuffers([[maybe_unused]] Camera *camera, S\n \tunsigned int count = stream->configuration().bufferCount;\n \n \tif (stream == &data->mainPathStream_)\n-\t\treturn mainPath_.video_->exportBuffers(count, buffers);\n+\t\treturn mainPath_.exportBuffers(count, buffers);\n \telse if (stream == &data->selfPathStream_)\n-\t\treturn selfPath_.video_->exportBuffers(count, buffers);\n+\t\treturn selfPath_.exportBuffers(count, buffers);\n \n \treturn -EINVAL;\n }\n@@ -1149,8 +1149,8 @@ bool PipelineHandlerRkISP1::match(DeviceEnumerator *enumerator)\n \tif (!selfPath_.init(media_))\n \t\treturn false;\n \n-\tmainPath_.video_->bufferReady.connect(this, &PipelineHandlerRkISP1::bufferReady);\n-\tselfPath_.video_->bufferReady.connect(this, &PipelineHandlerRkISP1::bufferReady);\n+\tmainPath_.bufferReady().connect(this, &PipelineHandlerRkISP1::bufferReady);\n+\tselfPath_.bufferReady().connect(this, &PipelineHandlerRkISP1::bufferReady);\n \tstat_->bufferReady.connect(this, &PipelineHandlerRkISP1::statReady);\n \tparam_->bufferReady.connect(this, &PipelineHandlerRkISP1::paramReady);\n \ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\nindex 7433ad03387dce0b..377772ca73877702 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h\n@@ -12,13 +12,15 @@\n #include <libcamera/camera.h>\n #include <libcamera/geometry.h>\n #include <libcamera/pixel_format.h>\n+#include <libcamera/signal.h>\n #include <libcamera/span.h>\n \n+#include \"libcamera/internal/v4l2_videodevice.h\"\n+\n namespace libcamera {\n \n class MediaDevice;\n class V4L2Subdevice;\n-class V4L2VideoDevice;\n struct StreamConfiguration;\n struct V4L2SubdeviceFormat;\n \n@@ -37,6 +39,15 @@ public:\n \tint configure(const StreamConfiguration &config,\n \t\t const V4L2SubdeviceFormat &inputFormat);\n \n+\tint exportBuffers(unsigned int bufferCount,\n+\t\t\t std::vector<std::unique_ptr<FrameBuffer>> *buffers)\n+\t{\n+\t\treturn video_->exportBuffers(bufferCount, buffers);\n+\t}\n+\n+\tint queueBuffer(FrameBuffer *buffer) { return video_->queueBuffer(buffer); }\n+\tSignal<FrameBuffer *> &bufferReady() { return video_->bufferReady; }\n+\n \t/* \\todo Make video private. */\n \tV4L2VideoDevice *video_;\n \n", "prefixes": [ "libcamera-devel", "v4", "4/7" ] }