Patch Detail
Show a patch.
GET /api/patches/9837/?format=api
{ "id": 9837, "url": "https://patchwork.libcamera.org/api/patches/9837/?format=api", "web_url": "https://patchwork.libcamera.org/patch/9837/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200928082858.2994-1-jacopo@jmondi.org>", "date": "2020-09-28T08:28:58", "name": "[libcamera-devel] libcamera: pipeline: Drop setStream() from configure() documentation", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "bc78f438f19a7ecc541f1e6ab5e50aec7384095e", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": { "id": 15, "url": "https://patchwork.libcamera.org/api/users/15/?format=api", "username": "jmondi", "first_name": "Jacopo", "last_name": "Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/patch/9837/mbox/", "series": [ { "id": 1329, "url": "https://patchwork.libcamera.org/api/series/1329/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1329", "date": "2020-09-28T08:28:58", "name": "[libcamera-devel] libcamera: pipeline: Drop setStream() from configure() documentation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1329/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/9837/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/9837/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83765C3B5C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Sep 2020 08:25:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CCB460364;\n\tMon, 28 Sep 2020 10:25:13 +0200 (CEST)", "from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C9776035F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Sep 2020 10:25:11 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id BE8B4100010;\n\tMon, 28 Sep 2020 08:25:10 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Sep 2020 10:28:58 +0200", "Message-Id": "<20200928082858.2994-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: Drop setStream()\n\tfrom configure() documentation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There is no requirement for Stream to be assigned to StreamConfiguration\nduring PipelineHandler::configure(). It actually happens at validate()\ntime in most implementations right now.\n\nDrop this requirement from PipelineHandler::configure() documentation.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline_handler.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 918aea1e8328..713fe6d1d362 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -314,10 +314,6 @@ const ControlList &PipelineHandler::properties(const Camera *camera) const\n * perform further validation and may rely on any custom field stored in its\n * custom CameraConfiguration derived class.\n *\n- * When configuring the camera the pipeline handler shall associate a Stream\n- * instance to each StreamConfiguration entry in the CameraConfiguration using\n- * the StreamConfiguration::setStream() method.\n- *\n * \\context This function is called from the CameraManager thread.\n *\n * \\return 0 on success or a negative error code otherwise\n", "prefixes": [ "libcamera-devel" ] }